From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756292AbbLAONq (ORCPT ); Tue, 1 Dec 2015 09:13:46 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:46546 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755253AbbLAONo (ORCPT ); Tue, 1 Dec 2015 09:13:44 -0500 Message-Id: <1448979224.3359384.454695137.2DC07EE8@webmail.messagingengine.com> X-Sasl-Enc: NOmm7/5ZAb+UKqUiupCdDZ2h1O6aoNsDlVtP+2GgtGSl 1448979224 From: Hannes Frederic Sowa To: "Eric W. Biederman" , David Miller Cc: Richard Weinberger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, bridge@lists.linux-foundation.org, Stephen Hemminger , Kees Cook MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface - ajax-b94e6169 Subject: Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace Date: Tue, 01 Dec 2015 15:13:44 +0100 In-Reply-To: <87egf7183c.fsf_-_@x220.int.ebiederm.org> References: <565B7F7D.80208@nod.at> <87egf7183c.fsf_-_@x220.int.ebiederm.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 30, 2015, at 22:38, Eric W. Biederman wrote: > Signed-off-by: "Eric W. Biederman" > --- > net/bridge/br_stp_if.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c > index 5396ff08af32..742fa89528ab 100644 > --- a/net/bridge/br_stp_if.c > +++ b/net/bridge/br_stp_if.c > @@ -142,7 +142,9 @@ static void br_stp_start(struct net_bridge *br) > char *envp[] = { NULL }; > struct net_bridge_port *p; > > - r = call_usermodehelper(BR_STP_PROG, argv, envp, UMH_WAIT_PROC); > + r = -ENOENT; > + if (dev_net(br->dev) == &init_net) net_eq ? > + r = call_usermodehelper(BR_STP_PROG, argv, envp, > UMH_WAIT_PROC); > > spin_lock_bh(&br->lock); > Otherwise, ack, so far. As our /sys interfaces directories are tagged by the net namespace it would actually make sense to run bridge-stp automatically in another name space. Bye, Hannes