mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Seth Jennings <sjennings@variantweb.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Seth Jennings <sjennings@variantweb.net>,
	Andrew Banman <abanman@sgi.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Russ Anderson <rja@sgi.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] drivers: memory: clean up section counting
Date: Wed,  2 Dec 2015 09:06:59 -0600	[thread overview]
Message-ID: <1449068821-9870-1-git-send-email-sjennings@variantweb.net> (raw)

Right now, section_count is calculated in add_memory_block().
However, init_memory_block() increments section_count as well,
which, at first, seems like it would lead to an off-by-one error.
There is no harm done because add_memory_block() immediately overwrites
the mem->section_count, but it is messy.

This commit moves the increment out of the common init_memory_block()
(called by both add_memory_block() and register_new_memory()) and
adds it to register_new_memory().

Signed-off-by: Seth Jennings <sjennings@variantweb.net>
---
 drivers/base/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 2804aed..ca2ce02 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -614,7 +614,6 @@ static int init_memory_block(struct memory_block **memory,
 			base_memory_block_id(scn_nr) * sections_per_block;
 	mem->end_section_nr = mem->start_section_nr + sections_per_block - 1;
 	mem->state = state;
-	mem->section_count++;
 	start_pfn = section_nr_to_pfn(mem->start_section_nr);
 	mem->phys_device = arch_get_memory_phys_device(start_pfn);
 
@@ -668,6 +667,7 @@ int register_new_memory(int nid, struct mem_section *section)
 		ret = init_memory_block(&mem, section, MEM_OFFLINE);
 		if (ret)
 			goto out;
+		mem->section_count++;
 	}
 
 	if (mem->section_count == sections_per_block)
-- 
2.5.0

             reply	other threads:[~2015-12-02 15:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 15:06 Seth Jennings [this message]
2015-12-02 15:07 ` [PATCH 2/3] drivers: memory: rename remove_memory_block() to remove_memory_section() Seth Jennings
2015-12-02 15:07 ` [PATCH 3/3] drivers: memory: prohibit offlining of memory blocks with missing sections Seth Jennings
2015-12-02 22:45   ` Andrew Morton
2015-12-03 17:58     ` [PATCH] drivers: memory: check for missing sections when testing zones Andrew Banman
2015-12-05  0:03       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449068821-9870-1-git-send-email-sjennings@variantweb.net \
    --to=sjennings@variantweb.net \
    --cc=abanman@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rja@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®