mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Saurabh Sengar <saurabh.truth@gmail.com>
To: gregkh@linuxfoundation.org, mathias.nyman@intel.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Saurabh Sengar <saurabh.truth@gmail.com>
Subject: [PATCH v2] usb: host: pci_quirks: fix memory leak, by adding iounmap
Date: Wed,  2 Dec 2015 22:51:37 +0530	[thread overview]
Message-ID: <1449076897-4617-1-git-send-email-saurabh.truth@gmail.com> (raw)
In-Reply-To: <20151202162924.GB32113@kroah.com>

added iounmap inorder to free memory mapped to base before returning

Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
v2: changed logic a bit, because of recent patches pushed to usb-next
 drivers/usb/host/pci-quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index 26cb8c8..2ac198c 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -992,7 +992,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
 	if ((ext_cap_offset + sizeof(val)) > len) {
 		/* We're reading garbage from the controller */
 		dev_warn(&pdev->dev, "xHCI controller failing to respond");
-		return;
+		goto hc_init;
 	}
 	val = readl(base + ext_cap_offset);
 
-- 
1.9.1


  reply	other threads:[~2015-12-02 17:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06 12:16 [PATCH] " Saurabh Sengar
2015-11-30  6:28 ` Saurabh Sengar
2015-11-30  9:05   ` Mathias Nyman
2015-12-01 22:35 ` Greg KH
2015-12-02  3:38   ` Saurabh Sengar
2015-12-02 15:45     ` Greg KH
2015-12-02 15:55       ` Saurabh Sengar
2015-12-02 16:29         ` Greg KH
2015-12-02 17:21           ` Saurabh Sengar [this message]
2015-12-04 16:23             ` [PATCH v2] " Greg KH
2015-12-04 16:31               ` Saurabh Sengar
2015-12-04 16:39               ` [PATCH v3] " Saurabh Sengar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449076897-4617-1-git-send-email-saurabh.truth@gmail.com \
    --to=saurabh.truth@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome