From: Li Bin <huawei.libin@huawei.com>
To: <rostedt@goodmis.org>, <will.deacon@arm.com>
Cc: <catalin.marinas@arm.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <mingo@redhat.com>,
<guohanjun@huawei.com>, <dingtianhong@huawei.com>
Subject: [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code
Date: Fri, 4 Dec 2015 10:18:39 +0800 [thread overview]
Message-ID: <1449195519-17901-3-git-send-email-huawei.libin@huawei.com> (raw)
In-Reply-To: <1449195519-17901-1-git-send-email-huawei.libin@huawei.com>
There is no need to worry about module text disappearing case,
because that ftrace has a module notifier that is called when
a module is being unloaded and before the text goes away, and this
code grabs the ftrace_lock mutex and removes the module functions
from the ftrace list, such that it will no longer do any
modifications to that module's text.
The update to make functions be traced or not is done under the
ftrace_lock mutex as well.
Signed-off-by: Li Bin <huawei.libin@huawei.com>
---
arch/arm64/kernel/ftrace.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/kernel/ftrace.c b/arch/arm64/kernel/ftrace.c
index 9669b33..ee91c0c 100644
--- a/arch/arm64/kernel/ftrace.c
+++ b/arch/arm64/kernel/ftrace.c
@@ -29,12 +29,9 @@ static int ftrace_modify_code(unsigned long pc, u32 old, u32 new,
/*
* Note:
- * Due to modules and __init, code can disappear and change,
+ * Due to __init, code can disappear and change,
* we need to protect against faulting as well as code changing.
* We do this by aarch64_insn_*() which use the probe_kernel_*().
- *
- * No lock is held here because all the modifications are run
- * through stop_machine().
*/
if (validate) {
if (aarch64_insn_read((void *)pc, &replaced))
--
1.7.1
next prev parent reply other threads:[~2015-12-04 2:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 2:18 [PATCH v2 0/2] arm64: stop using kstop_machine for ftrace Li Bin
2015-12-04 2:18 ` [PATCH v2 1/2] arm64: ftrace: stop using kstop_machine to enable/disable tracing Li Bin
2015-12-04 3:12 ` Steven Rostedt
2015-12-04 2:18 ` Li Bin [this message]
2015-12-04 2:50 ` [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code Steven Rostedt
2015-12-04 3:23 ` Li Bin
2015-12-04 6:36 ` Li Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449195519-17901-3-git-send-email-huawei.libin@huawei.com \
--to=huawei.libin@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=dingtianhong@huawei.com \
--cc=guohanjun@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®