From: "Matias Bjørling" <m@bjorling.me>
To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@fb.com
Cc: "Matias Bjørling" <m@bjorling.me>
Subject: [PATCH 5/9] lightnvm: comments on constants
Date: Sun, 6 Dec 2015 11:25:47 +0100 [thread overview]
Message-ID: <1449397551-16525-6-git-send-email-m@bjorling.me> (raw)
In-Reply-To: <1449397551-16525-1-git-send-email-m@bjorling.me>
It is not obvious what NVM_IO_* and NVM_BLK_T_* are used for. Make sure
to comment them appropriately as the other constants.
Signed-off-by: Matias Bjørling <m@bjorling.me>
---
include/linux/lightnvm.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
index c6916ae..935ef38 100644
--- a/include/linux/lightnvm.h
+++ b/include/linux/lightnvm.h
@@ -50,9 +50,16 @@ enum {
NVM_IO_DUAL_ACCESS = 0x1,
NVM_IO_QUAD_ACCESS = 0x2,
+ /* NAND Access Modes */
NVM_IO_SUSPEND = 0x80,
NVM_IO_SLC_MODE = 0x100,
NVM_IO_SCRAMBLE_DISABLE = 0x200,
+
+ /* Block Types */
+ NVM_BLK_T_FREE = 0x0,
+ NVM_BLK_T_BAD = 0x1,
+ NVM_BLK_T_DEV = 0x2,
+ NVM_BLK_T_HOST = 0x4,
};
struct nvm_id_group {
--
2.1.4
next prev parent reply other threads:[~2015-12-06 10:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 10:25 [PATCH 0/9] Fixes for LightNVM Matias Bjørling
2015-12-06 10:25 ` [PATCH 1/9] lightnvm: use flags in rrpc_get_blk Matias Bjørling
2015-12-06 10:25 ` [PATCH 2/9] lightnvm: put blks when luns configure failed Matias Bjørling
2015-12-06 10:25 ` [PATCH 3/9] lightnvm: refactor spin_unlock in gennvm_get_blk Matias Bjørling
2015-12-06 10:25 ` [PATCH 4/9] lightnvm: check mm before use Matias Bjørling
2015-12-06 10:25 ` Matias Bjørling [this message]
2015-12-06 10:25 ` [PATCH 6/9] lightnvm: replace req queue with nvmdev for lld Matias Bjørling
2015-12-06 10:25 ` [PATCH 7/9] lightnvm: fix media mgr registration Matias Bjørling
2015-12-06 10:25 ` [PATCH 8/9] lightnvm: prevent gennvm module unload on use Matias Bjørling
2015-12-06 10:25 ` [PATCH 9/9] lightnvm: do not compile in debugging by default Matias Bjørling
2015-12-07 16:11 ` [PATCH 0/9] Fixes for LightNVM Jens Axboe
2015-12-07 17:52 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449397551-16525-6-git-send-email-m@bjorling.me \
--to=m@bjorling.me \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®