mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ken Xue <ken.xue@amd.com>
To: <rjw@rjwysocki.net>, <lenb@kernel.org>,
	<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <SPG_Linux_Kernel@amd.com>, <mika.westerberg@linux.intel.com>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	<Ivan.Zheng@amd.com>, <Alex.Chuang@amd.com>
Subject: [PATCH 1/1] ACPI: Support D3 COLD device for old BIOS
Date: Mon, 7 Dec 2015 12:44:33 +0800	[thread overview]
Message-ID: <1449463473.2175.13.camel@kxue-X58A-UD3R> (raw)

D3cold is only regarded as valid if the "_PR3" object is present
for the given device after the commit <20dacb71ad28>
(ACPI/PM: Reworkdevice power management to follow ACPI 6).

But some old BIOS only defined "_PS3" for the D3COLD device.
And old kernel also believes the device has "_PS3" is a
D3COLD device.

So, add some logics for supporting D3 COLD device for old BIOS
which is compatible with earlier ACPI spec.

Signed-off-by: Ken Xue <Ken.Xue@amd.com>
Reported-and-tested-by: Gang Long <Gang.Long@amd.com>

---
 drivers/acpi/scan.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 01136b8..85c16bb 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -979,7 +979,9 @@ static void acpi_bus_get_power_flags(struct acpi_device *device)
 		acpi_bus_init_power_state(device, i);
 
 	INIT_LIST_HEAD(&device->power.states[ACPI_STATE_D3_COLD].resources);
-	if (!list_empty(&device->power.states[ACPI_STATE_D3_HOT].resources))
+	if (!list_empty(&device->power.states[ACPI_STATE_D3_HOT].resources) ||
+		((acpi_gbl_FADT.header.revision < 6) &&
+		device->power.states[ACPI_STATE_D3_HOT].flags.explicit_set))
 		device->power.states[ACPI_STATE_D3_COLD].flags.valid = 1;
 
 	/* Set defaults for D0 and D3hot states (always valid) */
-- 
1.9.1






             reply	other threads:[~2015-12-07  5:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07  4:44 Ken Xue [this message]
2015-12-07 22:48 ` Rafael J. Wysocki
2015-12-08  1:37   ` Ken Xue
2015-12-08 13:14     ` Rafael J. Wysocki
2015-12-09  1:18       ` Ken Xue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449463473.2175.13.camel@kxue-X58A-UD3R \
    --to=ken.xue@amd.com \
    --cc=Alex.Chuang@amd.com \
    --cc=Ivan.Zheng@amd.com \
    --cc=SPG_Linux_Kernel@amd.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®