From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: devel@linuxdriverproject.org
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/5] Drivers: hv: ring_buffer: remove stray smp_read_barrier_depends()
Date: Tue, 8 Dec 2015 18:07:37 +0100 [thread overview]
Message-ID: <1449594460-22588-3-git-send-email-vkuznets@redhat.com> (raw)
In-Reply-To: <1449594460-22588-1-git-send-email-vkuznets@redhat.com>
smp_read_barrier_depends() does nothing on almost all arcitectures
including x86 and having it in the beginning of
hv_get_ringbuffer_availbytes() does not provide any guarantees anyway.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
include/linux/hyperv.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 8fdc17b..1777dc8 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -141,8 +141,6 @@ hv_get_ringbuffer_availbytes(struct hv_ring_buffer_info *rbi,
{
u32 read_loc, write_loc, dsize;
- smp_read_barrier_depends();
-
/* Capture the read/write indices before they changed */
read_loc = rbi->ring_buffer->read_index;
write_loc = rbi->ring_buffer->write_index;
--
2.4.3
next prev parent reply other threads:[~2015-12-08 17:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 17:07 [PATCH v2 0/5] Drivers: hv: ring_buffer: do some code cleanup and optimization Vitaly Kuznetsov
2015-12-08 17:07 ` [PATCH v2 1/5] Drivers: hv: ring_buffer.c: fix comment style Vitaly Kuznetsov
2015-12-08 17:07 ` Vitaly Kuznetsov [this message]
2015-12-08 17:07 ` [PATCH v2 3/5] Drivers: hv: ring_buffer: remove code duplication from hv_ringbuffer_peek/read() Vitaly Kuznetsov
2015-12-08 17:07 ` [PATCH v2 4/5] Drivers: hv: remove code duplication between vmbus_recvpacket()/vmbus_recvpacket_raw() Vitaly Kuznetsov
2015-12-08 17:07 ` [PATCH v2 5/5] Drivers: hv: ring_buffer: eliminate hv_ringbuffer_peek() Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449594460-22588-3-git-send-email-vkuznets@redhat.com \
--to=vkuznets@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®