mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 6/9] test_hexdump: switch to memcmp()
Date: Wed,  9 Dec 2015 02:50:02 +0200	[thread overview]
Message-ID: <1449622205-25619-7-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1449622205-25619-1-git-send-email-andriy.shevchenko@linux.intel.com>

Better to use memcmp() against entire buffer to check that nothing is happened
to the data in the tail.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 lib/test_hexdump.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c
index 141d031..4b949aa 100644
--- a/lib/test_hexdump.c
+++ b/lib/test_hexdump.c
@@ -72,8 +72,6 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize,
 	else
 		result = test_data_1_le;
 
-	memset(test, FILL_CHAR, testlen);
-
 	/* hex dump */
 	p = test;
 	for (i = 0; i < l / gs; i++) {
@@ -109,13 +107,15 @@ static void __init test_hexdump(size_t len, int rowsize, int groupsize,
 	char test[TEST_HEXDUMP_BUF_SIZE];
 	char real[TEST_HEXDUMP_BUF_SIZE];
 
+	memset(real, FILL_CHAR, sizeof(real));
 	hex_dump_to_buffer(data_b, len, rowsize, groupsize, real, sizeof(real),
 			   ascii);
 
+	memset(test, FILL_CHAR, sizeof(test));
 	test_hexdump_prepare_test(len, rowsize, groupsize, test, sizeof(test),
 				  ascii);
 
-	if (strcmp(test, real)) {
+	if (memcmp(test, real, TEST_HEXDUMP_BUF_SIZE)) {
 		pr_err("Len: %zu row: %d group: %d\n", len, rowsize, groupsize);
 		pr_err("Result: '%s'\n", real);
 		pr_err("Expect: '%s'\n", test);
-- 
2.6.2


  parent reply	other threads:[~2015-12-09  0:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09  0:49 [PATCH v2 0/9] hexdump: update test suite Andy Shevchenko
2015-12-09  0:49 ` [PATCH v2 1/9] test_hexdump: rename to test_hexdump Andy Shevchenko
2015-12-09  0:49 ` [PATCH v2 2/9] test_hexdump: introduce test_hexdump_prepare_test() helper Andy Shevchenko
2015-12-09  0:49 ` [PATCH v2 3/9] test_hexdump: define FILL_CHAR constant Andy Shevchenko
2015-12-09  0:50 ` [PATCH v2 4/9] test_hexdump: go through all possible lengths of buffer Andy Shevchenko
2015-12-09  0:50 ` [PATCH v2 5/9] test_hexdump: replace magic numbers by their meaning Andy Shevchenko
2015-12-09  0:50 ` Andy Shevchenko [this message]
2015-12-09  0:50 ` [PATCH v2 7/9] test_hexdump: check all bytes in real buffer Andy Shevchenko
2015-12-09  0:50 ` [PATCH v2 8/9] test_hexdump: test all possible group sizes for overflow Andy Shevchenko
2015-12-09  0:50 ` [PATCH v2 9/9] test_hexdump: print statistics at the end Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449622205-25619-7-git-send-email-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome