From: "Geyslan G. Bem" <geyslan@gmail.com>
To: peter.senna@gmail.com
Cc: "Geyslan G. Bem" <geyslan@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/9] usb: host: ehci.h: fix single statement macros
Date: Wed, 9 Dec 2015 19:15:32 -0300 [thread overview]
Message-ID: <1449699341-12969-4-git-send-email-geyslan@gmail.com> (raw)
In-Reply-To: <1449699341-12969-1-git-send-email-geyslan@gmail.com>
Don't use the 'do {} while (0)' wrapper in a single statement macro.
Caught by cppcheck: "WARNING: Single statement macros should not
use a do {} while (0) loop"
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
drivers/usb/host/ehci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index cfeebd8..945000a 100644
--- a/drivers/usb/host/ehci.h
+++ b/drivers/usb/host/ehci.h
@@ -244,9 +244,9 @@ struct ehci_hcd { /* one per controller */
/* irq statistics */
#ifdef EHCI_STATS
struct ehci_stats stats;
-# define COUNT(x) do { (x)++; } while (0)
+# define COUNT(x) ((x)++)
#else
-# define COUNT(x) do {} while (0)
+# define COUNT(x) ((void) 0)
#endif
/* debug files */
--
2.6.3
next prev parent reply other threads:[~2015-12-09 22:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 22:15 [PATCH 1/9] usb: host: ehci.h: remove space before comma Geyslan G. Bem
2015-12-09 22:15 ` [PATCH 2/9] usb: host: ehci.h: remove space before function open parenthesis Geyslan G. Bem
2015-12-09 22:15 ` [PATCH 3/9] usb: host: ehci.h: remove space before open square bracket Geyslan G. Bem
2015-12-09 22:15 ` Geyslan G. Bem [this message]
2015-12-09 22:15 ` [PATCH 5/9] usb: host: ehci.h: remove direct use of __attribute__ keyword Geyslan G. Bem
2015-12-09 22:15 ` [PATCH 6/9] usb: host: ehci.h: use space after comma Geyslan G. Bem
2015-12-09 22:15 ` [PATCH 7/9] usb: host: ehci.h: remove macros trailing semicolon Geyslan G. Bem
2015-12-09 22:15 ` [PATCH 8/9] usb: host: ehci.h: move pointer operator to name side Geyslan G. Bem
2015-12-09 22:15 ` [PATCH 9/9] usb: host: ehci.h: move constant to right Geyslan G. Bem
2015-12-10 10:23 ` Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449699341-12969-4-git-send-email-geyslan@gmail.com \
--to=geyslan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome