From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753552AbbLJHzY (ORCPT ); Thu, 10 Dec 2015 02:55:24 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:30285 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752436AbbLJHzV (ORCPT ); Thu, 10 Dec 2015 02:55:21 -0500 X-AuditID: cbfec7f4-f79026d00000418a-ff-56692fe6a6b6 From: Andrzej Hajda To: linux-wireless@vger.kernel.org (open list:NFC SUBSYSTEM) Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] NFC: fdp: fix handling return value of nci_conn_max_data_pkt_payload_size Date: Thu, 10 Dec 2015 08:54:04 +0100 Message-id: <1449734044-29181-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNJMWRmVeSWpSXmKPExsVy+t/xK7rP9DPDDA4917a4te4cq8Xi7fdY LDbOWM9qsW3xFGaLy7vmsFm8WXGH3WLtkbvsFqe7WR04POadDPSYO/MXm0ffllWMHp83yQWw RHHZpKTmZJalFunbJXBl/Fy6j6ngFVfFg6OfmRoYP3B0MXJySAiYSFyYcp0VwhaTuHBvPVsX IxeHkMBSRolL05+yQDhNTBLn531lA6liE9CU+Lv5JpgtImAj8XzLLCaQImaBs0wSr75NBksI C8RIXOu+zwxiswioShzet5ARxOYVcJZYerWTCWKdnMTJY5NZJzByL2BkWMUomlqaXFCclJ5r qFecmFtcmpeul5yfu4kREiRfdjAuPmZ1iFGAg1GJh9dBLjNMiDWxrLgy9xCjBAezkgjv0Z8Z YUK8KYmVValF+fFFpTmpxYcYpTlYlMR55+56HyIkkJ5YkpqdmlqQWgSTZeLglGpgbH1Y4xlW 8O/Yrd05BwtOmxxIkhSsvaISUyZzNj6wc8fvxQ8Od+47nNOmGLj886o+G57I/3XFcZwTTmj9 +7LXYMZ6mS4lJrEXNu6fw0K4Jx5nPLlU/g+rmXbb3oRCucYPBUu4efJZXqlrd4iff5M+5Y9a 0bE1tt++x87Uds46/L/4qozDOaYdSizFGYmGWsxFxYkARRRMHw4CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative values, so its result should be assigned to signed variable. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- drivers/nfc/fdp/fdp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c index 440fac3..37a7134 100644 --- a/drivers/nfc/fdp/fdp.c +++ b/drivers/nfc/fdp/fdp.c @@ -192,7 +192,7 @@ static int fdp_nci_send_patch(struct nci_dev *ndev, u8 conn_id, u8 type) struct sk_buff *skb; unsigned long len; u8 max_size, payload_size; - int rc = 0; + int rc; if ((type == NCI_PATCH_TYPE_OTP && !info->otp_patch) || (type == NCI_PATCH_TYPE_RAM && !info->ram_patch)) @@ -203,11 +203,13 @@ static int fdp_nci_send_patch(struct nci_dev *ndev, u8 conn_id, u8 type) else fw = info->ram_patch; - max_size = nci_conn_max_data_pkt_payload_size(ndev, conn_id); - if (max_size <= 0) + rc = nci_conn_max_data_pkt_payload_size(ndev, conn_id); + if (rc <= 0) return -EINVAL; + max_size = rc; len = fw->size; + rc = 0; fdp_nci_set_data_pkt_counter(ndev, fdp_nci_send_patch_cb, DIV_ROUND_UP(fw->size, max_size)); -- 1.9.1