From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754639AbbLJH45 (ORCPT ); Thu, 10 Dec 2015 02:56:57 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:33214 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754583AbbLJH4z (ORCPT ); Thu, 10 Dec 2015 02:56:55 -0500 X-AuditID: cbfec7f5-f79b16d000005389-a3-56693045b389 From: Andrzej Hajda To: rtc-linux@googlegroups.com (open list:REAL TIME CLOCK (RTC) SUBSYSTEM) Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] rtc: rv8803: fix handling return value of i2c_smbus_read_byte_data Date: Thu, 10 Dec 2015 08:55:33 +0100 Message-id: <1449734133-29235-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNJMWRmVeSWpSXmKPExsVy+t/xy7quBplhBtcWs1rcWneO1WLJxavs Fh3XFjNZbJyxntXi8q45bBZrj9xlt9jf2cHowO7xZNNFRo89E0+yefRtWcXoMX3eTyaPz5vk AlijuGxSUnMyy1KL9O0SuDIWvy4ueMtWcX7PTuYGxsesXYycHBICJhLXTnaxQNhiEhfurWfr YuTiEBJYyijx9uwNJginiUnicVsHI0gVm4CmxN/NN9lAbBEBL4nt974zgxQxCyxkkji9axlY QlggVKJ36hugbg4OFgFVidaDMSBhXgFnibt3PzJCbJOTOHlsMusERu4FjAyrGEVTS5MLipPS c430ihNzi0vz0vWS83M3MUKC5OsOxqXHrA4xCnAwKvHwvpDODBNiTSwrrsw9xCjBwawkwnv0 Z0aYEG9KYmVValF+fFFpTmrxIUZpDhYlcd6Zu96HCAmkJ5akZqemFqQWwWSZODilGhhPbHTo vt44WXa7jEIjg0nTp38W3t2nnbrPuat7b17Hvks8P+rN6bMxfyIPHrv+ZaG+DGvjigRvFof/ lekrOnK2OSzPzOxaVflhY3/3M7abDx+66F0zD3icahVp9FR2luFz61VpCzVeinEnsDe8L7DR Uj7Sd+Lr3h+rfvuf/iom9H2n5fa0545KLMUZiYZazEXFiQCuXlG+DgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative values, so its result should be assigned to signed variable. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- drivers/rtc/rtc-rv8803.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c index e7329e2..f883aa2 100644 --- a/drivers/rtc/rtc-rv8803.c +++ b/drivers/rtc/rtc-rv8803.c @@ -61,7 +61,7 @@ static irqreturn_t rv8803_handle_irq(int irq, void *dev_id) struct i2c_client *client = dev_id; struct rv8803_data *rv8803 = i2c_get_clientdata(client); unsigned long events = 0; - u8 flags; + int flags; spin_lock(&rv8803->flags_lock); -- 1.9.1