From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753782AbbLJIgX (ORCPT ); Thu, 10 Dec 2015 03:36:23 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:32850 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbbLJIgV (ORCPT ); Thu, 10 Dec 2015 03:36:21 -0500 X-AuditID: cbfec7f5-f79b16d000005389-c3-5669398281b8 From: Andrzej Hajda To: linux-wireless@vger.kernel.org (open list:NFC SUBSYSTEM) Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2] NFC: fdp: fix handling return value of fdp_nci_create_conn Date: Thu, 10 Dec 2015 09:35:03 +0100 Message-id: <1449736503-6615-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1449733982-29120-1-git-send-email-a.hajda@samsung.com> References: <1449733982-29120-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMLMWRmVeSWpSXmKPExsVy+t/xq7pNlplhBg0/TC1urTvHarF4+z0W i40z1rNabFs8hdni8q45bBZvVtxht1h75C67xeluVgcOj3knAz3mzvzF5tG3ZRWjx+dNcgEs UVw2Kak5mWWpRfp2CVwZH7f8YSpYx13R+XQrawPjFM4uRk4OCQETiX+9a9ghbDGJC/fWs3Ux cnEICSxllLg9tZcJwmlikvj1diYrSBWbgKbE38032UBsEQEbiedbZoEVMQucZZJ49W0yWEJY wE9i38PZjCA2i4CqxMm+V0wgNq+Ak8SXVVvZINbJSZw8NhlsKKeAi0Tr4i6wGiEBZ4l5R76z TGDkXcDIsIpRNLU0uaA4KT3XSK84Mbe4NC9dLzk/dxMjJKi+7mBceszqEKMAB6MSD+8L6cww IdbEsuLK3EOMEhzMSiK8R39mhAnxpiRWVqUW5ccXleakFh9ilOZgURLnnbnrfYiQQHpiSWp2 ampBahFMlomDU6qBsbSnK6reXmlGiGmBjLPvTMPmubVtywvUwptyq7d8qp19ct3UiRdiemUu VlfeXTQt8/baTlZtsX2sW6/FzeVYtuuSpaS3yfU/Gxsr4p4JBL16mLYyM+DtW/Pp065amWqa pi+c//Vtd6mmx66crclbbj5tN37zf4Wx94NTG7eKr7vZ6/fkeqjaCiWW4oxEQy3mouJEAOsK oOQmAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative values, so its result should be assigned to signed variable. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- v2: fixed typo in goto instruction drivers/nfc/fdp/fdp.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c index ccb07a1..4dfd1ef 100644 --- a/drivers/nfc/fdp/fdp.c +++ b/drivers/nfc/fdp/fdp.c @@ -368,11 +368,10 @@ static int fdp_nci_patch_otp(struct nci_dev *ndev) goto out; /* Patch data connection creation */ - conn_id = fdp_nci_create_conn(ndev); - if (conn_id < 0) { - r = conn_id; + r = fdp_nci_create_conn(ndev); + if (r < 0) goto out; - } + conn_id = r; /* Send the patch over the data connection */ r = fdp_nci_send_patch(ndev, conn_id, NCI_PATCH_TYPE_OTP); @@ -439,11 +438,10 @@ static int fdp_nci_patch_ram(struct nci_dev *ndev) goto out; /* Patch data connection creation */ - conn_id = fdp_nci_create_conn(ndev); - if (conn_id < 0) { - r = conn_id; + r = fdp_nci_create_conn(ndev); + if (r < 0) goto out; - } + conn_id = r; /* Send the patch over the data connection */ r = fdp_nci_send_patch(ndev, conn_id, NCI_PATCH_TYPE_RAM); -- 1.9.1