From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753461AbbLKQyn (ORCPT <rfc822;w@1wt.eu>);
	Fri, 11 Dec 2015 11:54:43 -0500
Received: from mga11.intel.com ([192.55.52.93]:52061 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751624AbbLKQyl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 11 Dec 2015 11:54:41 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,414,1444719600"; 
   d="scan'208";a="839337264"
Message-ID: <1449852880.3057.15.camel@schen9-desk2.jf.intel.com>
Subject: Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "H. Peter Anvin" <hpa@zytor.com>, "David S.Miller" <davem@davemloft.net>,
        Stephan Mueller <smueller@chronox.de>,
        Chandramouli Narayanan <mouli_7982@yahoo.com>,
        Vinodh Gopal <vinodh.gopal@intel.com>,
        James Guilford <james.guilford@intel.com>,
        Wajdi Feghali <wajdi.k.feghali@intel.com>,
        Jussi Kivilinna <jussi.kivilinna@iki.fi>, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Fri, 11 Dec 2015 08:54:40 -0800
In-Reply-To: <20151211032340.GC10399@gondor.apana.org.au>
References: <cover.1449091633.git.tim.c.chen@linux.intel.com>
	 <1449086565.22260.15.camel@schen9-desk2.jf.intel.com>
	 <20151209025242.GA24861@gondor.apana.org.au>
	 <1449681794.22260.58.camel@schen9-desk2.jf.intel.com>
	 <20151210014519.GA31692@gondor.apana.org.au>
	 <1449765585.3057.9.camel@schen9-desk2.jf.intel.com>
	 <20151211032340.GC10399@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.8.5 (3.8.5-2.fc19) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2015-12-11 at 11:23 +0800, Herbert Xu wrote:
> On Thu, Dec 10, 2015 at 08:39:45AM -0800, Tim Chen wrote:
> >
> > The inner cipher is called synchronously from the outer layer 
> > async cipher algorithm in cbc_mb_async_ablk_decrypt via
> > 
> >         err = crypto_blkcipher_crt(child_tfm)->decrypt(
> >                 &rctx->desc, req->dst, req->src, req->nbytes);
> 
> We should avoid bypassing the API and directly calling crypto
> driver functions like this.
> 
> What if you made it a proper ablkcipher and just called it through
> the API?
> 
> Thanks,

Direct call I assume have less overhead.  Let me think about
making the inner cipher ablkcipher.  I may need to rewrite a lot
of the glue layer :(

Tim