From: "Geyslan G. Bem" <geyslan@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: "Geyslan G. Bem" <geyslan@gmail.com>,
joe@perches.com, peter.senna@gmail.com,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: host: ehci-sched: silence checkpatch warning
Date: Fri, 11 Dec 2015 22:50:20 -0300 [thread overview]
Message-ID: <1449885021-25261-1-git-send-email-geyslan@gmail.com> (raw)
This patch moves comment into the else branch avoiding the following
misleading warning.
"braces {} are not necessary for single statement blocks"
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
Suggested-by: Joe Perches <joe@perches.com>
---
drivers/usb/host/ehci-sched.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
index f6e828a..b2af0b3 100644
--- a/drivers/usb/host/ehci-sched.c
+++ b/drivers/usb/host/ehci-sched.c
@@ -1560,13 +1560,10 @@ iso_stream_schedule(
(stream->ps.bw_period - 1);
stream->ps.phase_uf = start & 7;
reserve_release_iso_bandwidth(ehci, stream, 1);
- }
-
- /* New stream is already scheduled; use the upcoming slot */
- else {
+ } else {
+ /* New stream is already scheduled; use the upcoming slot */
start = (stream->ps.phase << 3) + stream->ps.phase_uf;
}
-
stream->next_uframe = start;
new_stream = true;
}
--
2.6.3
next reply other threads:[~2015-12-12 1:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 1:50 Geyslan G. Bem [this message]
2015-12-12 2:02 ` Geyslan G. Bem
2015-12-12 16:19 ` Alan Stern
2015-12-12 16:39 ` Geyslan G. Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449885021-25261-1-git-send-email-geyslan@gmail.com \
--to=geyslan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®