From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755863AbbLLC5E (ORCPT ); Fri, 11 Dec 2015 21:57:04 -0500 Received: from mail-oi0-f46.google.com ([209.85.218.46]:34772 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755660AbbLLC5A (ORCPT ); Fri, 11 Dec 2015 21:57:00 -0500 From: Boqun Feng To: linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christopher Li , "Paul E . McKenney" , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Andy Whitcroft , Joe Perches , Thomas Gleixner , Jiang Liu , Marc Zyngier , Mika Westerberg , Russell King , Brian Norris , Peter Zijlstra , Boqun Feng Subject: [RFC 3/3] irq: Privatize irq_common_data::state_use_accessors Date: Sat, 12 Dec 2015 10:56:02 +0800 Message-Id: <1449888962-29348-4-git-send-email-boqun.feng@gmail.com> X-Mailer: git-send-email 2.6.4 In-Reply-To: <1449888962-29348-1-git-send-email-boqun.feng@gmail.com> References: <1449888962-29348-1-git-send-email-boqun.feng@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to Peter Zijlstra, irq_common_data::state_use_accessors is not designed for public use. Therefore make it private so that people who write code accessing it directly will get blamed by sparse. Signed-off-by: Boqun Feng --- include/linux/irq.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/irq.h b/include/linux/irq.h index 3c1c967..0b8f273 100644 --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -137,7 +137,7 @@ struct irq_domain; * @msi_desc: MSI descriptor */ struct irq_common_data { - unsigned int state_use_accessors; + unsigned int __private state_use_accessors; #ifdef CONFIG_NUMA unsigned int node; #endif @@ -208,7 +208,7 @@ enum { IRQD_FORWARDED_TO_VCPU = (1 << 20), }; -#define __irqd_to_state(d) ((d)->common->state_use_accessors) +#define __irqd_to_state(d) ACCESS_PRIVATE((d)->common, state_use_accessors) static inline bool irqd_is_setaffinity_pending(struct irq_data *d) { -- 2.6.4