From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755813AbbLLCtX (ORCPT ); Fri, 11 Dec 2015 21:49:23 -0500 Received: from p3plsmtps2ded04.prod.phx3.secureserver.net ([208.109.80.198]:42150 "EHLO p3plsmtps2ded04.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754673AbbLLCsW (ORCPT ); Fri, 11 Dec 2015 21:48:22 -0500 x-originating-ip: 72.167.245.219 From: "K. Y. Srinivasan" To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com Cc: "K. Y. Srinivasan" Subject: [PATCH 26/27] Drivers: hv: utils: Invoke the poll function after handshake Date: Fri, 11 Dec 2015 20:21:46 -0800 Message-Id: <1449894107-3389-26-git-send-email-kys@microsoft.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1449894107-3389-1-git-send-email-kys@microsoft.com> References: <1449894084-3348-1-git-send-email-kys@microsoft.com> <1449894107-3389-1-git-send-email-kys@microsoft.com> X-CMAE-Envelope: MS4wfLUnTU88VcBBo5kfbsqYwADnJ1GbBJfHjyAlUznfOzrKV1LJ1/CM6461TSIoCj2pVQSNew0PPtH6cRZL+jG59h1oiWvffYIQn40s8gPGOn2nMmcEUXs3 Yez87yor9CoTFtxTPbWGNCnj04KR/EWw+HjxKt5Q/GH2fArudLBvwZgJ0NF4z7ZRRcvbLbvXNEVf4HjHikblk24KtuAaFZ22ep3Cdta1t4eXbirbEWaX1Bnk Fi8mstcN+YOjgcdkAsCqj2hBkvjFqXdEl+MrjwaORFAeb+c0B6LVB4doJz07ltKsi8QNd7tNDsWzm4U5wVtElQ9QV5vFdzTsKvjECQk5hjrxAdc17gIWuiuQ WYTK1TiIJdNRkhpF6+Ln3eMCzauKkaAwmJb2PUb2QFXgCtDFm3BC+Nm3oM+e/6eF2hCeo83q Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the handshake with daemon is complete, we should poll the channel since during the handshake, we will not be processing any messages. This is a potential bug if the host is waiting for a response from the guest. I would like to thank Dexuan for pointing this out. Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_kvp.c | 2 +- drivers/hv/hv_snapshot.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hv/hv_kvp.c b/drivers/hv/hv_kvp.c index 2a3420c..d4ab81b 100644 --- a/drivers/hv/hv_kvp.c +++ b/drivers/hv/hv_kvp.c @@ -154,7 +154,7 @@ static int kvp_handle_handshake(struct hv_kvp_msg *msg) pr_debug("KVP: userspace daemon ver. %d registered\n", KVP_OP_REGISTER); kvp_register(dm_reg_value); - kvp_transaction.state = HVUTIL_READY; + hv_poll_channel(kvp_transaction.recv_channel, kvp_poll_wrapper); return 0; } diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_snapshot.c index 81882d4..67def4a 100644 --- a/drivers/hv/hv_snapshot.c +++ b/drivers/hv/hv_snapshot.c @@ -113,7 +113,7 @@ static int vss_handle_handshake(struct hv_vss_msg *vss_msg) default: return -EINVAL; } - vss_transaction.state = HVUTIL_READY; + hv_poll_channel(vss_transaction.recv_channel, vss_poll_wrapper); pr_debug("VSS: userspace daemon ver. %d registered\n", dm_reg_value); return 0; } -- 1.7.4.1