From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755031AbaHGSbC (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Aug 2014 14:31:02 -0400
Received: from senator.holtmann.net ([87.106.208.187]:36386 "EHLO
	mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750754AbaHGSbA convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Aug 2014 14:31:00 -0400
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: [PATCH] 6lowpan: Allow 6LoWPAN to be modular
From: Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <CAMuHMdU214_aDNQBH=Nk6DZwsdCB3FQY1DY0ZQ8WQGQ86dGFUQ@mail.gmail.com>
Date: Thu, 7 Aug 2014 11:31:11 -0700
Cc: Alexander Aring <alex.aring@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-zigbee-devel@lists.sourceforge.net,
        BlueZ development <linux-bluetooth@vger.kernel.org>,
        linux-wpan@vger.kernel.org,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <144B79BA-C835-4EF4-8FF5-533D535A5143@holtmann.org>
References: <1407424003-15073-1-git-send-email-geert@linux-m68k.org> <ABE15994-F47B-4E4B-A6FC-79C6BCAC9FF3@holtmann.org> <CAMuHMdU214_aDNQBH=Nk6DZwsdCB3FQY1DY0ZQ8WQGQ86dGFUQ@mail.gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
X-Mailer: Apple Mail (2.1878.6)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Geert,

>>> Change config symbol 6LOWPAN from type bool to type tristate, so
>>> 6LoWPAN can be built modular, just like IPV6
>>> 
>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>> ---
>>> net/6lowpan/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/net/6lowpan/Kconfig b/net/6lowpan/Kconfig
>>> index 028a5c6d1f61..e4a02ef55102 100644
>>> --- a/net/6lowpan/Kconfig
>>> +++ b/net/6lowpan/Kconfig
>>> @@ -1,5 +1,5 @@
>>> config 6LOWPAN
>>> -     bool "6LoWPAN Support"
>>> +     tristate "6LoWPAN Support"
>> 
>> is this a regression from the previous CONFIG_6LOWPAN separation that we introduced? If it is, then it might be easiest if Dave just takes it into his net tree. Otherwise I take it through bluetooth-next.
> 
> I hadn't thought about that... Checking...
> 
> Yes, I believe this is a regression.
> 
> In v3.16, my allmodconfig build had:
> 
> CONFIG_IEEE802154_6LOWPAN=m
> CONFIG_6LOWPAN_IPHC=m
> CONFIG_BT_6LOWPAN=y
> 
> Without my patch it has:
> 
> CONFIG_6LOWPAN=y
> CONFIG_IEEE802154_6LOWPAN=m
> CONFIG_BT_6LOWPAN=m
> 
> and iphc is what's in net/6lowpan/built-in.o now.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Dave, I am fine if you just queue this up for 3.17-rc1.

Regards

Marcel