mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Timber <dxdt@dev.snart.me>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 02/17] fs: add generic FS_IOC_SHUTDOWN definitions
Date: Sat, 21 Feb 2026 15:17:30 +0900	[thread overview]
Message-ID: <144a192d-1298-4aa4-891d-cf5e2ad6b8e6@dev.snart.me> (raw)
In-Reply-To: <20260213081804.13351-3-linkinjeon@kernel.org>

> +/*
> + * Shutdown the filesystem.
> + */
> +#define FS_IOC_SHUTDOWN _IOR('X', 125, __u32)
Should've been _IOW, not _IOR. This is rather unfortunate.

Documentation/userspace-api/ioctl/ioctl-number.rst:
>     ====== ===========================
>     macro  parameters
>     ====== ===========================
>     _IO    none
>     _IOW   write (read from userspace)
>     _IOR   read (write to userspace)
>     _IOWR  write and read
>     ====== ===========================
>
> 'Write' and 'read' are from the user's point of view, just like the
> system calls 'write' and 'read'.  For example, a SET_FOO ioctl would
> be _IOW, although the kernel would actually read data from user space;
> a GET_FOO ioctl would be _IOR, although the kernel would actually write
> data to user space.
All the *_ioctl_shutdown() do get_user(..., arg).

  reply	other threads:[~2026-02-21  6:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  8:17 [PATCH v9 00/17] ntfs filesystem remake Namjae Jeon
2026-02-13  8:17 ` [PATCH v9 01/17] Revert "fs: Remove NTFS classic" Namjae Jeon
2026-02-13  8:17 ` [PATCH v9 02/17] fs: add generic FS_IOC_SHUTDOWN definitions Namjae Jeon
2026-02-21  6:17   ` David Timber [this message]
2026-02-21  7:10     ` Darrick J. Wong
2026-02-13  8:17 ` [PATCH v9 03/17] ntfs: update in-memory, on-disk structures and headers Namjae Jeon
2026-02-13  8:17 ` [PATCH v9 04/17] ntfs: update super block operations Namjae Jeon
2026-02-13  8:17 ` [PATCH v9 05/17] ntfs: update inode operations Namjae Jeon
2026-02-13  8:17 ` [PATCH v9 06/17] ntfs: update mft operations Namjae Jeon
2026-02-13  8:17 ` [PATCH v9 07/17] ntfs: update directory operations Namjae Jeon
2026-02-13  8:17 ` [PATCH v9 08/17] ntfs: update file operations Namjae Jeon
2026-02-13  8:17 ` [PATCH v9 09/17] ntfs: update iomap and address space operations Namjae Jeon
2026-02-13  8:17 ` [PATCH v9 10/17] ntfs: update attrib operations Namjae Jeon
2026-05-03 12:49   ` Matthew Wilcox
2026-05-03 13:33     ` Namjae Jeon
2026-02-13  8:17 ` [PATCH v9 11/17] ntfs: update runlist handling and cluster allocator Namjae Jeon
2026-02-13  8:17 ` [PATCH v9 12/17] ntfs: add reparse and ea operations Namjae Jeon
2026-02-13  8:18 ` [PATCH v9 13/17] ntfs: update misc operations Namjae Jeon
2026-02-13  8:18 ` [PATCH v9 14/17] ntfs3: remove legacy ntfs driver support Namjae Jeon
2026-02-13  8:18 ` [PATCH v9 15/17] ntfs: add Kconfig and Makefile Namjae Jeon
2026-02-13  8:18 ` [PATCH v9 16/17] Documentation: filesystems: update NTFS driver documentation Namjae Jeon
2026-02-13  8:18 ` [PATCH v9 17/17] MAINTAINERS: update ntfs filesystem entry Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=144a192d-1298-4aa4-891d-cf5e2ad6b8e6@dev.snart.me \
    --to=dxdt@dev.snart.me \
    --cc=linkinjeon@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®