From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6E54C41604 for ; Tue, 6 Oct 2020 12:21:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6892720663 for ; Tue, 6 Oct 2020 12:21:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="vjTotTy8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726596AbgJFMVz (ORCPT ); Tue, 6 Oct 2020 08:21:55 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:52534 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbgJFMVy (ORCPT ); Tue, 6 Oct 2020 08:21:54 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 096CLMDW003646; Tue, 6 Oct 2020 07:21:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1601986882; bh=Ajt9ibuYrJxtVllMh28OvHRU7fjyVHlUBUr+BALwdGs=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=vjTotTy8fD+GFfa5PqIra/Wgd42xLpEb8rqt+cIIuxIvEzDwCcl7dW9AIdXypsbDC 8KJfms0fnZnQULMjPVVVzkSmLN3+r9Fr9UUKHesfas9gv/wCUZDlQid4GrtP/81iZo 4fyMyV6L09NRrncvMcW0zk2uMdDQkfy1V99w0gXw= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 096CLMij011343 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 6 Oct 2020 07:21:22 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 6 Oct 2020 07:21:19 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 6 Oct 2020 07:21:19 -0500 Received: from [10.250.37.2] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 096CLJFt060768; Tue, 6 Oct 2020 07:21:19 -0500 Subject: Re: [PATCH] leds: lm3697: Fix out-of-bound access To: , Marek Behun CC: Pavel , Linux Leds , Linux Kernel References: <20201005141334.36d9441a@blackhole.sk> <3c5fce56-8604-a7d5-1017-8a075f67061e@ti.com> <966c3f39-1310-dd60-6f33-0d9464ed2ff1@ti.com> <20201005164808.slrtmsvmw4pvwppm@falbala.internal.home.lespocky.de> <20201005173227.GA6431@duo.ucw.cz> <20201006093356.6d25b280@blackhole.sk> From: Dan Murphy Message-ID: <144aa75a-4369-cd81-d7dc-2354a9afd7c5@ti.com> Date: Tue, 6 Oct 2020 07:21:14 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All On 10/6/20 6:59 AM, ultracoolguy@tutanota.com wrote: > While I do agree with you that having the child nodes be led strings make more sense, would it be possible to have, for example, three strings controlled by the same label? > > Oct 6, 2020, 07:33 by kabel@blackhole.sk: > >> By the way I just realized that the DT binding in this driver seems >> incorrect to me. >> >> The controller logically supports 3 LED strings, each having >> configurable control bank. There are two control banks. You can connect the HVLED outputs to either control bank A or B there is no individual control of the LED strings. >> But the DT binding supports 2 DT nodes, one for each control bank >> (identified by the `reg` property) and then `led-sources` says which >> string should be controlled by given bank. >> >> But taking in mind that DT should describe how devices are connected to >> each other, I think the child nodes in the binding should instead >> describe the 3 supported LED strings... The outputs in this case are virtual outputs which are the banks (A and B). Since the device is bank controlled the actual current sinks are not defined thus making the the banks the actual outputs. This is why the 'reg' property defines the control bank either A or B and the led-sources indicates the strings associated with the control bank. Dan