From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D755C433EF for ; Fri, 10 Jun 2022 15:24:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242177AbiFJPYl (ORCPT ); Fri, 10 Jun 2022 11:24:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234100AbiFJPYk (ORCPT ); Fri, 10 Jun 2022 11:24:40 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7015213D23 for ; Fri, 10 Jun 2022 08:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654874679; x=1686410679; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ZmN9F24xfWub7ZpgfngTxQnTs9AUGNWnHWe661GnoRc=; b=EUtSgflbWRWV5N/1YhU/UBtRPvSPC94sydprxvErCOhiPF8jxXr15CmP J3JoXInzL13th2zOOs61RYHTcV0bZcNHsS5rO1ddDXGmUn1K+jlBijd6T saCClYtOGY1lLEd1kIHnedSK3POM/EGPZbwsvyEhkDfxerHy3B6xdJDos FmiVatJcNl5QTfMyMLv1rWu49M/+MIoa9FVVK4GxiZn4SouxoW322g5Rf 5by6uEQbR0IALU8q+8IfDYBdzNjmmazO+o4AVPb3cSHaVb4y5WH06V0iF 743w6UL6znO1BXlbf8op7N0azRGXqu2D5XbDIObhJhW3Fb44gbHz8ByuK Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10374"; a="278457627" X-IronPort-AV: E=Sophos;i="5.91,290,1647327600"; d="scan'208";a="278457627" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 08:24:39 -0700 X-IronPort-AV: E=Sophos;i="5.91,290,1647327600"; d="scan'208";a="710980278" Received: from cpatrick-mobl.amr.corp.intel.com (HELO [10.209.109.10]) ([10.209.109.10]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 08:24:38 -0700 Message-ID: <144af1ab-1e7e-b75c-331c-d9c2e55b9062@intel.com> Date: Fri, 10 Jun 2022 08:24:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCHv3 7/8] x86: Expose untagging mask in /proc/$PID/arch_status Content-Language: en-US To: "Kirill A. Shutemov" , Dave Hansen , Andy Lutomirski , Peter Zijlstra Cc: x86@kernel.org, Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , "H . J . Lu" , Andi Kleen , Rick Edgecombe , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220610143527.22974-1-kirill.shutemov@linux.intel.com> <20220610143527.22974-8-kirill.shutemov@linux.intel.com> From: Dave Hansen In-Reply-To: <20220610143527.22974-8-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/10/22 07:35, Kirill A. Shutemov wrote: > +/* > + * Report architecture specific information > + */ > +int proc_pid_arch_status(struct seq_file *m, struct pid_namespace *ns, > + struct pid *pid, struct task_struct *task) > +{ > + /* > + * Report AVX512 state if the processor and build option supported. > + */ > + if (cpu_feature_enabled(X86_FEATURE_AVX512F)) > + avx512_status(m, task); > + > + seq_printf(m, "untag_mask:\t%#lx\n", mm_untag_mask(task->mm)); > + > + return 0; > +} Arch-specific gunk is great for, well, arch-specific stuff. AVX-512 and its, um, "quirks", really won't show up anywhere else. But x86 isn't even the first to be doing this address tagging business. Shouldn't we be talking to the ARM folks about a common way to do this?