mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kernel@vger.kernel.org, pmladek@suse.com,
	marco.crivellari@suse.com, gustavold@gmail.com,
	david.dai@linux.dev, kernel-team@meta.com
Subject: Re: [PATCH 4/5] workqueue: build percpu pwqs through the attrs path
Date: Mon, 31 Aug 2026 12:23:10 -1000	[thread overview]
Message-ID: <144b3dc986135ebe34f671cdd02bd8aa@kernel.org> (raw)
In-Reply-To: <20260819-wq_realsplit-v1-4-6ad3c3f48be8@debian.org>

Hello,

On Wed, Aug 19, 2026 at 07:37:38AM -0700, Breno Leitao wrote:
>  	if (!(wq->flags & WQ_UNBOUND)) {
> -		ret = alloc_and_link_percpu_pwqs(wq);
> +		ret = apply_workqueue_attrs_locked(wq, percpu_std_wq_attrs[highpri]);

Applied 4-5 to wq/for-7.4.

One note: if pwq allocation fails partway through
apply_wqattrs_prepare(), the already allocated pwqs are released through
pwq_release_worker, which isn't created until workqueue_init(). Percpu
workqueues are created before that, so an allocation failure in that
window now oopses instead of failing cleanly. An allocation failing that
early is unrecoverable anyway, so this doesn't need handling, but it
probably deserves a comment.

Thanks.

-- 
tejun

  reply	other threads:[~2026-08-31 22:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 14:37 [PATCH 0/5] workqueue: unify percpu and unbound pwq allocation Breno Leitao
2026-08-19 14:37 ` [PATCH 1/5] workqueue: move the unbound-only attrs check to apply_workqueue_attrs() Breno Leitao
2026-08-19 14:37 ` [PATCH 2/5] workqueue: resolve the backing pool in alloc_pwq() Breno Leitao
2026-08-19 14:37 ` [PATCH 3/5] workqueue: make the default pwq optional Breno Leitao
2026-08-26  8:22   ` Marco Crivellari
2026-08-26 16:33     ` Breno Leitao
2026-08-19 14:37 ` [PATCH 4/5] workqueue: build percpu pwqs through the attrs path Breno Leitao
2026-08-31 22:23   ` Tejun Heo [this message]
2026-08-19 14:37 ` [PATCH 5/5] workqueue: rename the pwq slot helpers shared with percpu Breno Leitao
2026-08-31 22:11 ` [PATCH 0/5] workqueue: unify percpu and unbound pwq allocation Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=144b3dc986135ebe34f671cdd02bd8aa@kernel.org \
    --to=tj@kernel.org \
    --cc=david.dai@linux.dev \
    --cc=gustavold@gmail.com \
    --cc=jiangshanlai@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.crivellari@suse.com \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®