From: Krzysztof Kozlowski <krzk@kernel.org>
To: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>,
lee@kernel.org, pavel@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH V3 1/2] dt-bindings: leds: pwm: Add enable-gpios property
Date: Thu, 3 Jul 2025 09:10:00 +0200 [thread overview]
Message-ID: <144df658-262f-423b-b099-8e36679ae761@kernel.org> (raw)
In-Reply-To: <20250703035256.225289-1-Qing-wu.Li@leica-geosystems.com.cn>
On 03/07/2025 05:52, LI Qingwu wrote:
> Some PWM LED chips have a dedicated enable GPIO.
> This commit adds the support to specify such GPIO.
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
"Add a dedicated enable GPIO, because some PWM LED chips (e.g. foo bar
models from baz boo) ..."
Give us concrete, verifiable example where this is present. You can also
upstream your DTS as a proof, works for me.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-07-03 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 3:52 LI Qingwu
2025-07-03 3:52 ` [PATCH V3 2/2] leds: pwm: Add optional GPIO enable pin support LI Qingwu
2025-07-10 9:37 ` Lee Jones
2025-07-14 3:32 ` LI Qingwu
2025-07-18 13:23 ` Lee Jones
2025-07-03 7:10 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=144df658-262f-423b-b099-8e36679ae761@kernel.org \
--to=krzk@kernel.org \
--cc=Qing-wu.Li@leica-geosystems.com.cn \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®