mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Geyslan G. Bem" <geyslan@gmail.com>
To: peter.senna@gmail.com
Cc: "Geyslan G. Bem" <geyslan@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v3 02/10] usb: host: ehci-sched: move constants to right
Date: Sun, 13 Dec 2015 13:59:31 -0300	[thread overview]
Message-ID: <1450025981-23398-3-git-send-email-geyslan@gmail.com> (raw)
In-Reply-To: <1450025981-23398-1-git-send-email-geyslan@gmail.com>

This patch moves the constants to right.

Tested by compilation only.
Caught by coccinelle:
scripts/coccinelle/misc/compare_const_fl.cocci

Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
 drivers/usb/host/ehci-sched.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
index e9f2ee7..c1d323c 100644
--- a/drivers/usb/host/ehci-sched.c
+++ b/drivers/usb/host/ehci-sched.c
@@ -330,7 +330,7 @@ static int __maybe_unused same_tt(struct usb_device *dev1,
  */
 static inline unsigned char tt_start_uframe(struct ehci_hcd *ehci, __hc32 mask)
 {
-	unsigned char smask = QH_SMASK & hc32_to_cpu(ehci, mask);
+	unsigned char smask = hc32_to_cpu(ehci, mask) & QH_SMASK;
 	if (!smask) {
 		ehci_err(ehci, "invalid empty smask!\n");
 		/* uframe 7 can't have bw so this will indicate failure */
@@ -409,11 +409,11 @@ static int tt_available (
 		 * must be empty, so as to not illegally delay
 		 * already scheduled transactions
 		 */
-		if (125 < usecs) {
+		if (usecs > 125) {
 			int ufs = (usecs / 125);
 
 			for (i = uframe; i < (uframe + ufs) && i < 8; i++)
-				if (0 < tt_usecs[i])
+				if (tt_usecs[i] > 0)
 					return 0;
 		}
 
-- 
2.6.3


  parent reply	other threads:[~2015-12-13 17:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-13 16:59 [PATCH v3 00/10] usb: host: ehci-sched: cleanup Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 01/10] usb: host: ehci-sched: refactor scan_isoc function Geyslan G. Bem
2015-12-13 16:59 ` Geyslan G. Bem [this message]
2015-12-13 16:59 ` [PATCH v3 03/10] usb: host: ehci-sched: remove useless initializations Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 04/10] usb: host: ehci-sched: add spaces around operators Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 05/10] usb: host: ehci-sched: remove prohibited spaces Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 06/10] usb: host: ehci-sched: remove useless else branch Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 07/10] usb: host: ehci-sched: use C89-style comments Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 08/10] usb: host: ehci-sched: add line after declarations Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 09/10] usb: host: ehci-sched: use sizeof operator with parens Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 10/10] usb: host: ehci-sched: remove unnecessary braces Geyslan G. Bem
2015-12-24 16:03 ` [PATCH v3 00/10] usb: host: ehci-sched: cleanup Geyslan G. Bem
2016-01-25  3:30   ` Greg Kroah-Hartman
2016-01-25 19:52     ` Geyslan G. Bem
2016-01-25 19:56       ` Greg Kroah-Hartman
2016-01-25 20:20         ` Geyslan G. Bem
2016-01-25 20:08       ` Alan Stern
2016-01-25 20:26         ` Geyslan G. Bem
2016-01-25 20:40           ` Alan Stern
2016-01-25 22:18             ` Geyslan G. Bem
2016-01-26  1:49               ` Geyslan G. Bem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450025981-23398-3-git-send-email-geyslan@gmail.com \
    --to=geyslan@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.senna@gmail.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome