From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932078AbbLNGi6 (ORCPT ); Mon, 14 Dec 2015 01:38:58 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:52112 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752612AbbLNGir (ORCPT ); Mon, 14 Dec 2015 01:38:47 -0500 X-AuditID: cbfee68f-f793a6d000001364-11-566e63f53fac From: Chanwoo Choi To: myungjoo.ham@samsung.com, k.kozlowski@samsung.com, kgene@kernel.org Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, cw00.choi@samsung.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v4 05/20] PM / devfreq: Add new passive governor Date: Mon, 14 Dec 2015 15:38:09 +0900 Message-id: <1450075104-13705-6-git-send-email-cw00.choi@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1450075104-13705-1-git-send-email-cw00.choi@samsung.com> References: <1450075104-13705-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsWyRsSkUPdrcl6YwYqFAhbXvzxntZh/5Byr Rf+bhawW516tZLR4/cLQov/xa2aLs01v2C0u75rDZvG59wijxYzz+5gs1m28xW5x+zKvxdLr F5ksbjeuYLOYMH0ti0Xr3iPsFm2rP7A6CHqsmbeG0aOluYfN43JfL5PHzll32T1WLv/C5rFp VSebx79j7B59W1YxenzeJBfAGcVlk5Kak1mWWqRvl8CV8fbANuaCx74VNz80sjUwLnLoYuTk kBAwkXi87B4jhC0mceHeerYuRi4OIYEVjBILt35kgSn6P7+fBSIxi1Hi4vmbTBDOF0aJpp5D YFVsAloS+1/cYAOxRQTcJb7e2w02ilngC5NE6+TvzCAJYQEHieO3n4DtYxFQlbi7v50JxOYV cJWYsWEeK8Q6OYkPex6xg9icAm4S+75OBxsqBFRzeD7IHC6gmkYOiauTlzJBDBKQ+DYZ5AoO oISsxKYDzBBzJCUOrrjBMoFReAEjwypG0dSC5ILipPQiY73ixNzi0rx0veT83E2MwIg7/e9Z /w7GuwesDzEKcDAq8fBmLMsNE2JNLCuuzD3EaAq0YSKzlGhyPjCu80riDY3NjCxMTUyNjcwt zZTEeRdK/QwWEkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnVwKhu3P3g8UeGFX9bhezOm05aFn6p fePv6muzX77pm1x3SFjHYv4WjYKWD3lq8/5drTM4cnxd4pprPH7GRdqxy/Uj56nny/72rr64 4/z0zUsZr133ubOkL2P2G+nKE2fFpe+12r+u4fg0J0xp5XKzZ/3zjWad7JGel2s0b23luqk/ OZ0ezr8blDhBiaU4I9FQi7moOBEA/mJsfbMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsVy+t9jQd2vyXlhBs2rOS2uf3nOajH/yDlW i/43C1ktzr1ayWjx+oWhRf/j18wWZ5vesFtc3jWHzeJz7xFGixnn9zFZrNt4i93i9mVei6XX LzJZ3G5cwWYxYfpaFovWvUfYLdpWf2B1EPRYM28No0dLcw+bx+W+XiaPnbPusnusXP6FzWPT qk42j3/H2D36tqxi9Pi8SS6AM6qB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJc SSEvMTfVVsnFJ0DXLTMH6BUlhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEN Y8bbA9uYCx77Vtz80MjWwLjIoYuRk0NCwETi//x+FghbTOLCvfVsXYxcHEICsxglLp6/yQTh fGGUaOo5BFbFJqAlsf/FDTYQW0TAXeLrvd1gHcwCX5gkWid/ZwZJCAs4SBy//YQRxGYRUJW4 u7+dCcTmFXCVmLFhHivEOjmJD3sesYPYnAJuEvu+TgcbKgRUc3j+d+YJjLwLGBlWMUqkFiQX FCel5xrlpZbrFSfmFpfmpesl5+duYgRH9TPpHYyHd7kfYhTgYFTi4c1clhsmxJpYVlyZe4hR goNZSYQ3wSovTIg3JbGyKrUoP76oNCe1+BCjKdBhE5mlRJPzgQknryTe0NjEzMjSyNzQwsjY XEmcd9+lyDAhgfTEktTs1NSC1CKYPiYOTqkGxpUGVQIGUaplbTJhxxpss14aXH4ar/NnwS1j 0+13wnhr/ZsjFlpNqspljpHqOHRz/m792LPNEz003uTLZl7eXFYV1KTdVfthxVL5nR682nH6 lRb+pbczXxTfrWjVut05r+Ptlkm37nR6r5nfrbyp8nx6oepU7SWP2oJvuJnXHppzxfz+q1uK SizFGYmGWsxFxYkAK1OYOgADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds the new passive governor for DEVFREQ framework. The following governors are already present and used for DVFS (Dynamic Voltage and Frequency Scaling) drivers. The following governors are independently used for one device driver which don't give the influence to other device drviers and also don't receive the effect from other device drivers. - ondemand / performance / powersave / userspace The passive governor depends on operation of parent driver with specific governos extremely and is not able to decide the new frequency by oneself. According to the decided new frequency of parent driver with governor, the passive governor uses it to decide the appropriate frequency for own device driver. The passive governor must need the following information from device tree: - the source clock and OPP tables - the instance of parent device For exameple, there are one more devfreq device drivers which need to change their source clock according to their utilization on runtime. But, they share the same power line (e.g., regulator). So, specific device driver is operated as parent with ondemand governor and then the rest device driver with passive governor is influenced by parent device. Suggested-by: Myungjoo Ham Signed-off-by: Chanwoo Choi [linux.amoon: Tested on Odroid U3] Tested-by: Anand Moon --- drivers/devfreq/Kconfig | 9 ++++ drivers/devfreq/Makefile | 1 + drivers/devfreq/devfreq.c | 47 ++++++++++++++++ drivers/devfreq/governor_passive.c | 108 +++++++++++++++++++++++++++++++++++++ include/linux/devfreq.h | 15 ++++++ 5 files changed, 180 insertions(+) create mode 100644 drivers/devfreq/governor_passive.c diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index 55ec774f794c..d03f635a93e1 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig @@ -64,6 +64,15 @@ config DEVFREQ_GOV_USERSPACE Otherwise, the governor does not change the frequnecy given at the initialization. +config DEVFREQ_GOV_PASSIVE + tristate "Passive" + help + Sets the frequency by other governors (simple_ondemand, performance, + powersave, usersapce) of a parent devfreq device. This governor + always has the dependency on the chosen frequency from paired + governor. This governor does not change the frequency by oneself + through sysfs entry. + comment "DEVFREQ Drivers" config ARM_EXYNOS_BUS_DEVFREQ diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile index 375ebbb4fcfb..f81c313b4b79 100644 --- a/drivers/devfreq/Makefile +++ b/drivers/devfreq/Makefile @@ -4,6 +4,7 @@ obj-$(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND) += governor_simpleondemand.o obj-$(CONFIG_DEVFREQ_GOV_PERFORMANCE) += governor_performance.o obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o +obj-$(CONFIG_DEVFREQ_GOV_PASSIVE) += governor_passive.o # DEVFREQ Drivers obj-$(CONFIG_ARCH_EXYNOS) += exynos/ diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 984c5e9e7bdd..15e58779e4c0 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -190,6 +190,31 @@ static struct devfreq_governor *find_devfreq_governor(const char *name) /* Load monitoring helper functions for governors use */ +static int update_devfreq_passive(struct devfreq *devfreq, unsigned long freq) +{ + struct devfreq *passive; + unsigned long rate; + int ret; + + list_for_each_entry(passive, &devfreq->passive_dev_list, passive_node) { + if (!passive->governor) + continue; + rate = freq; + + ret = passive->governor->get_target_freq(passive, &rate); + if (ret) + return ret; + + ret = passive->profile->target(passive->dev.parent, &rate, 0); + if (ret) + return ret; + + passive->previous_freq = rate; + } + + return 0; +} + /** * update_devfreq() - Reevaluate the device and configure frequency. * @devfreq: the devfreq instance. @@ -233,10 +258,18 @@ int update_devfreq(struct devfreq *devfreq) flags |= DEVFREQ_FLAG_LEAST_UPPER_BOUND; /* Use LUB */ } + if (!list_empty(&devfreq->passive_dev_list) + && devfreq->previous_freq > freq) + update_devfreq_passive(devfreq, freq); + err = devfreq->profile->target(devfreq->dev.parent, &freq, flags); if (err) return err; + if (!list_empty(&devfreq->passive_dev_list) + && devfreq->previous_freq < freq) + update_devfreq_passive(devfreq, freq); + if (devfreq->profile->freq_table) if (devfreq_update_status(devfreq, freq)) dev_err(&devfreq->dev, @@ -442,6 +475,10 @@ static void _remove_devfreq(struct devfreq *devfreq) return; } list_del(&devfreq->node); + list_del(&devfreq->passive_node); + if (!list_empty(&devfreq->passive_dev_list)) + list_del_init(&devfreq->passive_dev_list); + mutex_unlock(&devfreq_list_lock); if (devfreq->governor) @@ -559,6 +596,16 @@ struct devfreq *devfreq_add_device(struct device *dev, goto err_init; } + if (!strncmp(devfreq->governor_name, "passive", 7)) { + struct devfreq *parent_devfreq = + ((struct devfreq_passive_data *)data)->parent; + + list_add(&devfreq->passive_node, + &parent_devfreq->passive_dev_list); + } else { + INIT_LIST_HEAD(&devfreq->passive_dev_list); + } + return devfreq; err_init: diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c new file mode 100644 index 000000000000..7443ae4b92f9 --- /dev/null +++ b/drivers/devfreq/governor_passive.c @@ -0,0 +1,108 @@ +/* + * linux/drivers/devfreq/governor_passive.c + * + * Copyright (C) 2015 Samsung Electronics + * Author: Chanwoo Choi + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include +#include +#include +#include +#include "governor.h" + +static int devfreq_passive_get_target_freq(struct devfreq *passive, + unsigned long *freq) +{ + struct devfreq_passive_data *passive_data = passive->data; + struct devfreq *parent_devfreq = passive_data->parent; + unsigned long child_freq = ULONG_MAX; + int i, count; + + /* + * Each devfreq has the OPP table. After deciding the new frequency + * from the governor of parent devfreq device, the passive governor + * need to get the index of new frequency on OPP table of parent + * device. And then the index is used for getting the suitable + * new frequency for passive devfreq device. + */ + + if (!passive->profile || !passive->profile->freq_table + || passive->profile->max_state <= 0) + return -EINVAL; + + /* + * When new frequency is lower than previous frequency of parent + * devfreq device, passive governor get the correct frequency from OPP + * list of parent device. Because in this case, *freq is temporary + * value which is decided by ondemand governor. + */ + if (parent_devfreq->previous_freq > *freq) { + struct dev_pm_opp *opp; + opp = devfreq_recommended_opp(parent_devfreq->dev.parent, + freq, 0); + if (IS_ERR_OR_NULL(opp)) + return PTR_ERR(opp); + } + + /* + * Get the OPP table's index of decided freqeuncy by governor + * of parent device. + */ + for (i = 0; i < parent_devfreq->profile->max_state; i++) + if (parent_devfreq->profile->freq_table[i] == *freq) + break; + + if (i == parent_devfreq->profile->max_state) + return -EINVAL; + count = passive->profile->max_state; + + /* Get the suitable frequency by using index of parent device. */ + if (i < passive->profile->max_state) + child_freq = passive->profile->freq_table[i]; + else + child_freq = passive->profile->freq_table[count - 1]; + + /* Return the suitable frequency for passive device. */ + *freq = child_freq; + + return 0; +} + +static int devfreq_passive_event_handler(struct devfreq *devfreq, + unsigned int event, void *data) +{ + return 0; +} + +static struct devfreq_governor devfreq_passive = { + .name = "passive", + .get_target_freq = devfreq_passive_get_target_freq, + .event_handler = devfreq_passive_event_handler, +}; + +static int __init devfreq_passive_init(void) +{ + return devfreq_add_governor(&devfreq_passive); +} +subsys_initcall(devfreq_passive_init); + +static void __exit devfreq_passive_exit(void) +{ + int ret; + + ret = devfreq_remove_governor(&devfreq_passive); + if (ret) + pr_err("%s: failed remove governor %d\n", __func__, ret); + + return; +} +module_exit(devfreq_passive_exit); + +MODULE_AUTHOR("Chanwoo Choi "); +MODULE_DESCRIPTION("DEVFREQ Passive governor"); +MODULE_LICENSE("GPL v2"); diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h index 6fa02a20eb63..95c54578a1b4 100644 --- a/include/linux/devfreq.h +++ b/include/linux/devfreq.h @@ -177,6 +177,9 @@ struct devfreq { unsigned int *trans_table; unsigned long *time_in_state; unsigned long last_stat_updated; + + struct list_head passive_dev_list; + struct list_head passive_node; }; #if defined(CONFIG_PM_DEVFREQ) @@ -241,6 +244,18 @@ struct devfreq_simple_ondemand_data { }; #endif +/** + * struct devfreq_passive_data - void *data fed to struct devfreq + * and devfreq_add_device + * @parent: The parent devfreq device. + * + * If the fed devfreq_passive_data pointer is NULL to the governor, + * the governor return ERROR. + */ +struct devfreq_passive_data { + struct devfreq *parent; +}; + #else /* !CONFIG_PM_DEVFREQ */ static inline struct devfreq *devfreq_add_device(struct device *dev, struct devfreq_dev_profile *profile, -- 1.9.1