From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932261AbbLNLPI (ORCPT ); Mon, 14 Dec 2015 06:15:08 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:20474 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932121AbbLNLPG (ORCPT ); Mon, 14 Dec 2015 06:15:06 -0500 X-AuditID: cbfec7f5-f79b16d000005389-f3-566ea4b7ba84 From: Andrzej Hajda To: Chanwoo Choi , Krzysztof Kozlowski Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , MyungJoo Ham , linux-kernel@vger.kernel.org Subject: [PATCH] extcon: max77693: fix handling return value of regmap_irq_get_virq Date: Mon, 14 Dec 2015 12:12:42 +0100 Message-id: <1450091562-31811-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: References: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmluLIzCtJLcpLzFFi42I5/e/4Nd3tS/LCDG580Le4te4cq8XGGetZ La5/ec5q8fqFocXlXXPYLNYeuctucbtxBZsDu0ffllWMHp83yQUwRXHZpKTmZJalFunbJXBl HJ/zgr3gNHvFj5uL2BoY57F1MXJwSAiYSLx6btLFyAlkiklcuLceKMzFISSwlFHi6oe5jBBO E5NEy+dvjCBVbAKaEn8332QDsUUEIiXe7jjADlLELHCdUeLB7y1gRcICoRLz/r8EK2IRUJW4 suYLM4jNK+AscWzSNzaIdXISJ49NZgW5glMgWGLnCVmQsJBAgMSCjfuZJzDyLmBkWMUomlqa XFCclJ5rpFecmFtcmpeul5yfu4kREjRfdzAuPWZ1iFGAg1GJhzdjWW6YEGtiWXFl7iFGCQ5m JRFe5bl5YUK8KYmVValF+fFFpTmpxYcYpTlYlMR5Z+56HyIkkJ5YkpqdmlqQWgSTZeLglGpg XL8oKjL8iFlOJOf8lrsSTX/XOeUFqXw4Z3fzaZ+1uMTk0FkP047eeOmQzxlQvda5kGttS5Zz cECosUBqfkNuTNPBwiPLExT22dst9qt9P/n8AQ5eg6jeqXxHHHt8Htm/nPfm3bGKzaXH9ysY n2CpSb+e9FUqW11QZGWGpvWLo19qeUTuVocosRRnJBpqMRcVJwIA2+5V1xYCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative values, so its result should be assigned to signed variable. Signed-off-by: Andrzej Hajda Suggested-by: Krzysztof Kozlowski --- drivers/extcon/extcon-max77693.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c index 44c499e..fdf8f5d 100644 --- a/drivers/extcon/extcon-max77693.c +++ b/drivers/extcon/extcon-max77693.c @@ -1127,11 +1127,11 @@ static int max77693_muic_probe(struct platform_device *pdev) /* Support irq domain for MAX77693 MUIC device */ for (i = 0; i < ARRAY_SIZE(muic_irqs); i++) { struct max77693_muic_irq *muic_irq = &muic_irqs[i]; - unsigned int virq = 0; + int virq; virq = regmap_irq_get_virq(max77693->irq_data_muic, muic_irq->irq); - if (!virq) + if (virq <= 0) return -EINVAL; muic_irq->virq = virq; -- 1.9.1