mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: <kernel-team@fb.com>, <linux-kernel@vger.kernel.org>,
	<rostedt@goodmis.org>
Subject: [PATCH] trace-cmd: add trace_hash_find_reverse
Date: Tue, 15 Dec 2015 11:13:24 -0500	[thread overview]
Message-ID: <1450196004-1899-1-git-send-email-jbacik@fb.com> (raw)

Sometimes we want to FIFO identical entries in the hash table, so add
trace_hash_find_reverse, which will cycle through the hash list in reverse.
This is helpful in our case where we are monitoring block request issues to
match with their corresponding completes, if we issue multiple times to the same
block we want to be able to match them with the correct completes (more or less
anyway).  Thanks,

Signed-off-by: Josef Bacik <jbacik@fb.com>
---
 list.h       |  5 +++++
 trace-hash.c | 22 ++++++++++++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/list.h b/list.h
index 9817871..93c64f5 100644
--- a/list.h
+++ b/list.h
@@ -79,4 +79,9 @@ static inline int list_empty(struct list_head *list)
 	     &(p)->field != list;					\
 	     p = n, n = container_of((p)->field.next, typeof(*p), field))
 
+#define list_for_each_entry_reverse(p, list, field)			\
+	for (p = container_of((list)->prev, typeof(*p), field);		\
+	     &p->field != list;						\
+	     p = container_of((p)->field.prev, typeof(*p), field))
+
 #endif /* __LIST_H */
diff --git a/trace-hash.c b/trace-hash.c
index 5ffe61c..0dc4f73 100644
--- a/trace-hash.c
+++ b/trace-hash.c
@@ -94,3 +94,25 @@ trace_hash_find(struct trace_hash *hash, unsigned long long key,
 
 	return NULL;
 }
+
+struct trace_hash_item *
+trace_hash_find_reverse(struct trace_hash *hash, unsigned long long key,
+			trace_hash_func match, void *data)
+{
+	struct trace_hash_item *item;
+	struct list_head *bucket;
+	int bucket_nr = hash->power ? key & hash->power :
+		key % hash->nr_buckets;
+
+	bucket = hash->buckets + bucket_nr;
+	list_for_each_entry_reverse(item, bucket, list) {
+		if (item->key == key) {
+			if (!match)
+				return item;
+			if (match(item, data))
+				return item;
+		}
+	}
+
+	return NULL;
+}
-- 
2.5.0


             reply	other threads:[~2015-12-15 16:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 16:13 Josef Bacik [this message]
2016-02-23 22:26 ` Steven Rostedt
2016-02-24 18:25   ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450196004-1899-1-git-send-email-jbacik@fb.com \
    --to=jbacik@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®