From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965414AbbLOTCO (ORCPT ); Tue, 15 Dec 2015 14:02:14 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34193 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753949AbbLOTCM (ORCPT ); Tue, 15 Dec 2015 14:02:12 -0500 Message-ID: <1450206129.8474.48.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH] net: fix uninitialized variable issue From: Eric Dumazet To: Tadeusz Struk Cc: herbert@gondor.apana.org.au, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, freude@linux.vnet.ibm.com, viro@zeniv.linux.org.uk, linux-crypto@vger.kernel.org Date: Tue, 15 Dec 2015 11:02:09 -0800 In-Reply-To: <20151215184617.11620.23369.stgit@tstruk-mobl1> References: <20151215184617.11620.23369.stgit@tstruk-mobl1> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-12-15 at 10:46 -0800, Tadeusz Struk wrote: > msg_iocb needs to be initialized on the recv/recvfrom path. > Otherwise afalg will wrongly interpret it as an async call. > > Cc: stable@vger.kernel.org > Reported-by: Harald Freudenberger > Signed-off-by: Tadeusz Struk > --- > net/socket.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/socket.c b/net/socket.c > index dd2c247..80ca820 100644 > --- a/net/socket.c > +++ b/net/socket.c > @@ -1702,6 +1702,7 @@ SYSCALL_DEFINE6(recvfrom, int, fd, void __user *, ubuf, size_t, size, > msg.msg_name = addr ? (struct sockaddr *)&address : NULL; > /* We assume all kernel code knows the size of sockaddr_storage */ > msg.msg_namelen = 0; > + msg.msg_iocb = NULL; > if (sock->file->f_flags & O_NONBLOCK) > flags |= MSG_DONTWAIT; > err = sock_recvmsg(sock, &msg, iov_iter_count(&msg.msg_iter), flags); > Do not add "Cc: stable@vger.kernel.org" for networking patches, thanks ( Documentation/networking/netdev-FAQ.txt ) Do you know when was this bug added ? Please add the Fixes: 12-digit-sha1 ("patch title") Thanks.