From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linda Knippers <linda.knippers@hp.com>
Cc: Ethan Zhao <ethan.zhao@oracle.com>,
dirk.j.brandewie@intel.com, kristen@linux.intel.com,
viresh.kumar@linaro.org, corbet@lwn.net,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, ethan.kernel@gmail.com,
alexey.kodanev@oracle.com
Subject: Re: [PATCH 2/2 V8] intel_pstate: add kernel parameter to force loading.
Date: Fri, 05 Dec 2014 23:28:33 +0100 [thread overview]
Message-ID: <1450362.V0bfHnJ0NE@vostro.rjw.lan> (raw)
In-Reply-To: <5481D8B9.2030603@hp.com>
On Friday, December 05, 2014 11:09:29 AM Linda Knippers wrote:
> On 12/5/2014 4:40 AM, Ethan Zhao wrote:
> > To force loading on Oracle Sun X86 servers, provide one kernel command line
> > parameter
> >
> > intel_pstate = force
> >
> > For those who be aware of the risk of no power capping capabily working and
> > try to get better performance with this driver.
> >
> > Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com>
> > Tested-by: Alexey Kodanev <alexey.kodanev@oracle.com>
> > ---
> > v2: change to hardware vendor specific naming parameter.
> > v4: refine code and doc.
> > v5&v6: fix a typo in doc.
> > v7: change enum PCC to PPC.
> > v8: change the name of kernel command line parameter to generic one.
> >
> > Documentation/kernel-parameters.txt | 5 +++++
> > drivers/cpufreq/intel_pstate.c | 6 +++++-
> > 2 files changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> > index 479f332..7d0983e 100644
> > --- a/Documentation/kernel-parameters.txt
> > +++ b/Documentation/kernel-parameters.txt
> > @@ -1446,6 +1446,11 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
> > disable
> > Do not enable intel_pstate as the default
> > scaling driver for the supported processors
> > + force
> > + Enable intel_pstate on systems where it may cause problems to
> > + happen due to conflicts with platform firmware attempting to
> > + drive P-states by itself in certain situations (for thermal
> > + control or power capping in general or other purposes).
>
> I suggest something like:
> Enable intel_pstate on systems that prohibit it by
> default in favor of acpi-cpufreq. Forcing the
> intel_pstate driver instead of acpi-cpufreq may disable
> platform features, such as thermal controls and power
> capping, that rely on ACPI p-state information being
> used by the OS and therefore should be used with care.
> This option does not work with processors that aren't
> supported by the intel_pstate driver or on platforms
> that use pcc-cpufreq instead of acpi-cpufreq.
>
> Maybe this is too specific but I believe it is accurate. Comments?
Looks good to me, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2014-12-05 22:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 9:40 Ethan Zhao
2014-12-05 16:09 ` Linda Knippers
2014-12-05 22:28 ` Rafael J. Wysocki [this message]
2014-12-06 2:16 ` ethan
2014-12-06 17:36 ` Linda Knippers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450362.V0bfHnJ0NE@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=alexey.kodanev@oracle.com \
--cc=corbet@lwn.net \
--cc=dirk.j.brandewie@intel.com \
--cc=ethan.kernel@gmail.com \
--cc=ethan.zhao@oracle.com \
--cc=kristen@linux.intel.com \
--cc=linda.knippers@hp.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®