From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967030AbbLQPGF (ORCPT ); Thu, 17 Dec 2015 10:06:05 -0500 Received: from mail1.windriver.com ([147.11.146.13]:36351 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934373AbbLQPGC (ORCPT ); Thu, 17 Dec 2015 10:06:02 -0500 From: Paul Gortmaker To: CC: Paul Gortmaker , Nicolas Ferre , Jiri Slaby , , Greg Kroah-Hartman , Sudip Mukherjee Subject: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c Date: Thu, 17 Dec 2015 10:05:46 -0500 Message-ID: <1450364746-815-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.6.1 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular") we removed the code relating to modular support since it currently only supports built in. However, when redoing my build coverage for mips allmodconfig, which sets CONFIG_OF, I noticed a remaining line that needs to be removed, else we will get a build failure for an undefined module macro. Unfortunately this didn't appear for any of the other arch I tested more frequently, such as ARM. Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just remove the offending line. Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular") Cc: Nicolas Ferre Cc: Jiri Slaby Cc: linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman Cc: Sudip Mukherjee Reported-by: Sudip Mukherjee Signed-off-by: Paul Gortmaker --- drivers/tty/serial/atmel_serial.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c index 50e785a0ea73..1c0884d8ef32 100644 --- a/drivers/tty/serial/atmel_serial.c +++ b/drivers/tty/serial/atmel_serial.c @@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = { { .compatible = "atmel,at91sam9260-usart" }, { /* sentinel */ } }; - -MODULE_DEVICE_TABLE(of, atmel_serial_dt_ids); #endif static inline struct atmel_uart_port * -- 2.6.1