From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967068AbbLQPhk (ORCPT ); Thu, 17 Dec 2015 10:37:40 -0500 Received: from mga01.intel.com ([192.55.52.88]:4326 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756243AbbLQPhi (ORCPT ); Thu, 17 Dec 2015 10:37:38 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,441,1444719600"; d="scan'208";a="873573845" Message-ID: <1450366673.30729.144.camel@linux.intel.com> Subject: Re: [PATCH 3/3] ata: sata_dwc_460ex: get rid of global data From: Andy Shevchenko To: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= Cc: Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 17 Dec 2015 17:37:53 +0200 In-Reply-To: References: <1450221935-6034-1-git-send-email-mans@mansr.com> <1450221935-6034-3-git-send-email-mans@mansr.com> <1450364765.30729.139.camel@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-12-17 at 15:19 +0000, Måns Rullgård wrote: > Andy Shevchenko writes: > > > On Tue, 2015-12-15 at 23:25 +0000, Mans Rullgard wrote: > > > This moves all global data into the driver private struct, thus > > > permitting multiple devices of this type to be used. > > > > > > > Nice! > > > > Btw, last time Linus complained about new warnings. Most of them I > > have > > fixed when moved to external DMA driver. Leftovers IIRC are related > > to > > address space. Are you going to fix them? Otherwise it might be a > > headache for him again with strong wording to our address I > > suppose. > > There are some issues with __iomem annotations.  Is that the warnings > you refer to?  I'm not getting any regular compiler warnings. > I guess I got them because I'am checking sparse warnings as well. There is the original Linus' complain. http://permalink.gmane.org/gmane.linux.ide/59391 -- Andy Shevchenko Intel Finland Oy