From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
<linux-fsdevel@vger.kernel.org>
Subject: [PATCH 8/8] fs: make binfmt_elf.c explicitly non-modular
Date: Thu, 17 Dec 2015 14:11:06 -0500 [thread overview]
Message-ID: <1450379466-23115-9-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1450379466-23115-1-git-send-email-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
config BINFMT_ELF
bool "Kernel support for ELF binaries"
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
Since this file was already using core_initcall and not module_init,
we have no changes in initcall ordering with this commit.
We don't replace module.h with init.h since the file already has that.
We delete the MODULE_LICENSE tag and capture that information at the
top of the file alongside author comments, etc.
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
fs/binfmt_elf.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index 3a93755e880f..c26450ffbdc9 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -7,9 +7,9 @@
* Tools".
*
* Copyright 1993, 1994: Eric Youngdale (ericy@cais.com).
+ * License: GPL
*/
-#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/fs.h>
#include <linux/mm.h>
@@ -2324,13 +2324,4 @@ static int __init init_elf_binfmt(void)
register_binfmt(&elf_format);
return 0;
}
-
-static void __exit exit_elf_binfmt(void)
-{
- /* Remove the COFF and ELF loaders. */
- unregister_binfmt(&elf_format);
-}
-
core_initcall(init_elf_binfmt);
-module_exit(exit_elf_binfmt);
-MODULE_LICENSE("GPL");
--
2.6.1
prev parent reply other threads:[~2015-12-17 19:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 19:10 [PATCH v2 0/8] fs: don't use module helpers in non-modular code Paul Gortmaker
2015-12-17 19:10 ` [PATCH 1/8] hugetlb: make mm and fs code explicitly non-modular Paul Gortmaker
2015-12-17 22:45 ` Mike Kravetz
2015-12-18 2:46 ` Davidlohr Bueso
2015-12-17 19:11 ` [PATCH 2/8] fs: make notify dnotify.c " Paul Gortmaker
2015-12-17 19:11 ` [PATCH 3/8] fs: make fcntl.c " Paul Gortmaker
2015-12-17 19:11 ` [PATCH 4/8] fs: make filesystems.c " Paul Gortmaker
2015-12-17 19:11 ` [PATCH 5/8] fs: make locks.c " Paul Gortmaker
2015-12-18 12:07 ` Jeff Layton
2015-12-17 19:11 ` [PATCH 6/8] fs: make direct-io.c " Paul Gortmaker
2015-12-17 19:11 ` [PATCH 7/8] fs: make devpts/inode.c " Paul Gortmaker
2015-12-17 19:46 ` Peter Hurley
2015-12-20 2:52 ` Paul Gortmaker
2015-12-17 19:11 ` Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450379466-23115-9-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome