From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933391AbbLQUEK (ORCPT ); Thu, 17 Dec 2015 15:04:10 -0500 Received: from mail-am1on0079.outbound.protection.outlook.com ([157.56.112.79]:18560 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932327AbbLQUEI (ORCPT ); Thu, 17 Dec 2015 15:04:08 -0500 Authentication-Results: spf=fail (sender IP is 12.216.194.146) smtp.mailfrom=ezchip.com; ezchip.com; dkim=none (message not signed) header.d=none;ezchip.com; dmarc=none action=none header.from=ezchip.com; From: Chris Metcalf To: CC: Chris Metcalf Subject: [PATCH] tile: include the syscall number in the backtrace Date: Thu, 17 Dec 2015 15:03:56 -0500 Message-ID: <1450382636-5113-1-git-send-email-cmetcalf@ezchip.com> X-Mailer: git-send-email 2.1.2 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD035;1:zcglEWX0QTZxxq/Ivyc8jIb2pmqr1cbg2ODOdfuIKHsbmzBgOozyiBb9aQ3YInXOb2ZO0Fp2EHPvl7vzY1oNM/aRvnAvRhTypG8S8WWxaL8NsAeBaR1svdeofkLYuIXSW6CuDmamlJU6QhZ7DaCEHj2fIg4J15DPzfDFQRvS1p+jBDEn7QVS8GJUFNMkoLP1axb4VEu1UtAYZOAuVSBiPamCasF33qdoldqmI/HZg/VN2zm+Q1Wivzfu1IcG9k56NWlYXv0jn0pTqwpOTptjnOpWAsq6lu2gVExey6zFTRpDntn7dJ93AyB7SgYakGYdzmvisINcHt5QfWKANJKUqHIHWa0l/i3FYq7JCsHNuBbVNSE1s2BErINFr4K86R4i8B2/NZL5wuMpe4/PlRdfqg== X-Forefront-Antispam-Report: CIP:12.216.194.146;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(110136002)(450100001)(50466002)(229853001)(50226001)(48376002)(5008740100001)(11100500001)(5001970100001)(19580395003)(2351001)(36756003)(189998001)(6806005)(104016004)(4001430100002)(92566002)(33646002)(107886002)(86362001)(1096002)(105606002)(5003940100001)(50986999)(85426001)(19580405001)(87936001)(42186005)(586003)(106466001)(1220700001)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR02MB122;H:ld-1.internal.tilera.com;FPR:;SPF:Fail;PTR:wb-fw1.tilera.com;MX:1;A:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;DB3PR02MB122;2:6FuM++iILbJtyGHZo+4Il4M6CxU/R8lCf4UJ+AQCyoAUX6El2HlhciusnNdzQD30BndQfiILPmTSxjmI0p+DUwEdRR+kzZU6SZdwJylTEHkKw2Ec1t2kJ/OROuHLgUZJ8KCy/18K0+OxYPJkYzKxaQ==;3:Oqo4Icd1Yp1fHmOejhXR+1wxYJJpqIhjPwIrLzjKU28UumMxSfkxhryGu2pSItm04+v/LiZ3yC/giSK5mfvIIQ+Nv1kYRzB162S9eEe7IiT1DW98M1vy3rpzKfa7NTi5bw+gnDtyWP/IpAssr5RtWhw/UjcYBxadnvuTSGmeVsJiFCEL0z1wfwxvc9QqlnTxvht+AUg1nTsLZGtsurefcSLCEcNKfo9fHvd8Jx4PSsg=;25:4i1GAtixiyr0lqKT6CnlvMQ8FqrJDwH93D2/Pg4E2U8hAgyS7xFpm5Ripf9S8TQcgf8zyQGnWIQkP3Jq+1wwS+29hqq6ZFtJU5STGQDXTHHknIh+dCkTAv2CRNlXPiAXu0QuI7tGrHiVbROGBvNl2+ESN0RiK5SFzGgc8agbqop/0UWgGVKfEzzm5sne6nusGwjP6RsEjXfg4nSW/ltzafKgUR8omaC/QDsh/pHh2+KoEVgO97fK3VCojfEVS3N4R10Ypka7A0v/BjsmTgfDSA==;20:QFtwv8FLJrEBckrkBCcaIClpooi0UyPiAZdkYc0kmzT44hosPkVwEGbQlj8FnVfFoOvApS7jaXiSMjKjb2SOIARWREnn0RkLAZoTOAv6PdNUkDOeomLLe/jR9FqU33w+pFMdd9hzSnOQYyPZLD6ewq5O/K8qZ6hh3dN/NvNP6Qw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB3PR02MB122; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(121898900299872); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001);SRVR:DB3PR02MB122;BCL:0;PCL:0;RULEID:;SRVR:DB3PR02MB122; X-Microsoft-Exchange-Diagnostics: 1;DB3PR02MB122;4:OikhQjxSukjQEmRW5WabL8LBe3JehzypU1+JCB7OMS8n8MGTyhj4FbAWMKI5r8QkxT2t5s9rOGJymx92HDt5eDxETIUZuqan3CJwNTSspxUxWOvwm/cgomXFCSL2Q3ngTDvtxqzhyV9ea2cUVc3e/oK994tU1HjcDZe5EuFEkq8BIKnZdcW+HQsAYX+Bpdy4NvMBTSOr4pWXUfgkhEcyT1+RamCZkx+3BuNjeF0qRnH/qCcmpunVR8b344LHVkqlYqsKHbVvgVvysNDdPrQvklW64kkFYKOn4o1xDFDCXF9urAW0mRNKFsv20Sf6Iozrc3j/e1CP8kP6oLyPYM9gd+NBUWz3lmH3ZBpWV9tu2qKKvtwlEPAyGyq1/APl9Hzozv4XfYKfBzjVfNJd/m/maJzOg6sNEBh4HbEBm5kxOkzCsMg6NHi4bOpTh8TE5b63 X-Forefront-PRVS: 07935ACF08 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB3PR02MB122;23:jKgmhPn88C/dg2i0iAWj7276B+uyISkDU8eJnCciYw?= =?us-ascii?Q?RoQz3F16vW91Oc2KuqqtfvtstMXN4qYNGsR2Wl2C80QBeaUWRXj7+vkTm9KA?= =?us-ascii?Q?x+aam/o28ZMCpZ5+SqFWQGw8b6cXjnMIUEDIMM/tfUArFnK/7at9J74/C3or?= =?us-ascii?Q?jpp8o8r3gIrkaxI/YK5ul4O+j5nSXPb8CW3fs3qLRBZj5nN7ZfhLENh4k56B?= =?us-ascii?Q?ucziM91iBZPNOLGDmB6i1icYIUu1empVFXki/wURJBZk9RwJy6daWfyjuKel?= =?us-ascii?Q?ihiORvYpelXhIT2HdSUrfVdl5TTBcuRpbckSSY5WU7C8ypcWjvC5L5LWvbyu?= =?us-ascii?Q?qNNLEsVuL5r1EZK1S8tNnUlEp2jSFevSyTx3ejlfyN++fQjJf3mIFqlOcEDq?= =?us-ascii?Q?bMUvYoKo9vzwNUF46iNVURZl0B6IbO6BlLyOaUKke3PF5QjB5eaaztvPFgGF?= =?us-ascii?Q?Ix0+EwE7s7dZ5AnK0W1lW9WNlZqCE55YFsxuF56Fuxkn9Tvg5TGupKvlhmc1?= =?us-ascii?Q?blnL1OEn7QvD50+JMNCwG2KfzhS38QsehfcWOKbDQ86K2KkrtRa01Jm4VXSY?= =?us-ascii?Q?6vrEYkIckAFUsC4jtwQTVkfFm+SWbhuPD6ZA0FoRSRbz0cbDju5rl+NjiAaV?= =?us-ascii?Q?TffhXcbvBsshAdGApykvmLotFoQJPU89Ny1db3yKdoaFZdWTjubg/YtNfMD9?= =?us-ascii?Q?xwn1VALGdZO5yXUIm5TCgzIzMV8ADTCTaTro0RjLEKg7io2xMU0Qx8VZpW0Q?= =?us-ascii?Q?iNMaURjaePKh+hls3U9XgyI/pn+pEI3ylceXYVZu96Og0jEUijK6psodXWGO?= =?us-ascii?Q?UNJFNRtPMozagYYPHnFXJ8lun9J/yCPOzidKDey1/2rj1ScU2t7jwvY/MmOt?= =?us-ascii?Q?rgYn/CFE7WbjRS4FrQE4710swcXwZYLczmJCzE19UQWmy0CzkI9+LvhWrkBK?= =?us-ascii?Q?0g+ex6lGWInkqV7zxOFmKUbm2Bh8d9sgRpiQjxdviV2Ixsiw37E4Sz2q7iF1?= =?us-ascii?Q?Tqij9kaulpU+erCQKWIf+9I9vxNfaGsdg4O1APuRFAR5ftNUemtRYcwt6DMX?= =?us-ascii?Q?ACoas=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB3PR02MB122;5:+kpKatpECQ/4Y5VdLMt0+A3VV9yU+Q89LvspibMa9BfXeJzjYoNK8gHxky2M5NEYObRClJWB2+EivHgIB0PON3ENFqYaqsDmOBigBD3cYYtiGo6cmMM8FMvNsd2PJaK3M2NAc7txea+CnmNbdsPryA==;24:nUmcNEeclj9AcPOcZgXjAWF4il4g7Ns2i9HHx7PIrs7LK9aFAYcrgVuXaHSHSh/gFi448RR4Es07rCGNX5vDpJkk++RN8m5FOoSEl8qorSM= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2015 20:04:04.7777 (UTC) X-MS-Exchange-CrossTenant-Id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0fc16e0a-3cd3-4092-8b2f-0a42cff122c3;Ip=[12.216.194.146];Helo=[ld-1.internal.tilera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR02MB122 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This information is easily available in the backtrace data and can be helpful when trying to figure out the backtrace, particularly if we're early in kernel entry or late in kernel exit. Signed-off-by: Chris Metcalf --- arch/tile/kernel/stack.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/arch/tile/kernel/stack.c b/arch/tile/kernel/stack.c index 402b9c85a894..22bbbd3ff4a3 100644 --- a/arch/tile/kernel/stack.c +++ b/arch/tile/kernel/stack.c @@ -78,8 +78,7 @@ static bool read_memory_func(void *result, unsigned long address, /* Return a pt_regs pointer for a valid fault handler frame */ static struct pt_regs *valid_fault_handler(struct KBacktraceIterator* kbt) { - const char *fault = NULL; /* happy compiler */ - char fault_buf[64]; + char fault[64]; unsigned long sp = kbt->it.sp; struct pt_regs *p; @@ -90,14 +89,14 @@ static struct pt_regs *valid_fault_handler(struct KBacktraceIterator* kbt) if (!in_kernel_stack(kbt, sp + C_ABI_SAVE_AREA_SIZE + PTREGS_SIZE-1)) return NULL; p = (struct pt_regs *)(sp + C_ABI_SAVE_AREA_SIZE); - if (p->faultnum == INT_SWINT_1 || p->faultnum == INT_SWINT_1_SIGRETURN) - fault = "syscall"; - else { - if (kbt->verbose) { /* else we aren't going to use it */ - snprintf(fault_buf, sizeof(fault_buf), + if (kbt->verbose) { /* else we aren't going to use it */ + if (p->faultnum == INT_SWINT_1 || + p->faultnum == INT_SWINT_1_SIGRETURN) + snprintf(fault, sizeof(fault), + "syscall %ld", p->regs[TREG_SYSCALL_NR]); + else + snprintf(fault, sizeof(fault), "interrupt %ld", p->faultnum); - fault = fault_buf; - } } if (EX1_PL(p->ex1) == KERNEL_PL && __kernel_text_address(p->pc) && -- 2.1.2