From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932214AbbLVAB5 (ORCPT ); Mon, 21 Dec 2015 19:01:57 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:33052 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752288AbbLUXsG (ORCPT ); Mon, 21 Dec 2015 18:48:06 -0500 From: Al Viro To: linux-kernel@vger.kernel.org Cc: Linus Torvalds Subject: [POC][PATCH 38/83] usb_mon: get rid of pointless casts Date: Mon, 21 Dec 2015 23:47:11 +0000 Message-Id: <1450741676-5865-38-git-send-email-viro@ZenIV.linux.org.uk> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <20151221234615.GW20997@ZenIV.linux.org.uk> References: <20151221234615.GW20997@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro Signed-off-by: Al Viro --- drivers/usb/mon/mon_bin.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/usb/mon/mon_bin.c b/drivers/usb/mon/mon_bin.c index cdc68e5..26d497b 100644 --- a/drivers/usb/mon/mon_bin.c +++ b/drivers/usb/mon/mon_bin.c @@ -1305,17 +1305,16 @@ static int mon_bin_wait_event(struct file *file, struct mon_reader_bin *rp) static int mon_alloc_buff(struct mon_pgmap *map, int npages) { int n; - unsigned long vaddr; for (n = 0; n < npages; n++) { - vaddr = (unsigned long)get_zeroed_page(GFP_KERNEL); - if (vaddr == 0) { + void *vaddr = get_zeroed_page(GFP_KERNEL); + if (!vaddr) { while (n-- != 0) free_page(map[n].ptr); return -ENOMEM; } - map[n].ptr = (unsigned char *) vaddr; - map[n].pg = virt_to_page((void *) vaddr); + map[n].ptr = vaddr; + map[n].pg = virt_to_page(vaddr); } return 0; } -- 2.1.4