From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932653AbbLVOrE (ORCPT ); Tue, 22 Dec 2015 09:47:04 -0500 Received: from smtprelay0186.hostedemail.com ([216.40.44.186]:56163 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932243AbbLVOrA (ORCPT ); Tue, 22 Dec 2015 09:47:00 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:4321:4823:5007:6261:10004:10400:10848:11232:11658:11783:11889:11914:12043:12048:12296:12517:12519:12740:13069:13095:13311:13357:13523:13524:13894:14659:21080:21088:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: woman69_59c90c979c83b X-Filterd-Recvd-Size: 1926 Message-ID: <1450795615.21677.10.camel@perches.com> Subject: Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp From: Joe Perches To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" Date: Tue, 22 Dec 2015 06:46:55 -0800 In-Reply-To: <20151222011756.506380156@telegraphics.com.au> References: <20151222011737.980475848@telegraphics.com.au> <20151222011756.506380156@telegraphics.com.au> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-12-22 at 12:18 +1100, Finn Thain wrote: > This patch is just the result of two substitutions. The first removes any > tabs and spaces at the end of the line. The second replaces runs of > tabs and spaces at the beginning of comment lines with a single space. I think the second of these isn't done well. Many of these comments post reformatting are much worse to read because of lost alignment. For instance: > +/* >   * Function : int NCR5380_select(struct Scsi_Host *instance, > - *                               struct scsi_cmnd *cmd) > + * struct scsi_cmnd *cmd) >   * >   * Purpose : establishes I_T_L or I_T_L_Q nexus for new or existing command, > - *      including ARBITRATION, SELECTION, and initial message out for  > - *      IDENTIFY and queue messages.  > + * including ARBITRATION, SELECTION, and initial message out for > + * IDENTIFY and queue messages.