From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755034AbbLVP0a (ORCPT ); Tue, 22 Dec 2015 10:26:30 -0500 Received: from mga14.intel.com ([192.55.52.115]:62933 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754898AbbLVPZx (ORCPT ); Tue, 22 Dec 2015 10:25:53 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,464,1444719600"; d="scan'208";a="876833080" From: Alexander Shishkin To: Greg KH Cc: linux-kernel@vger.kernel.org, Chunyan Zhang , Alexander Shishkin Subject: [PATCH v3 6/9] stm class: Fix an off-by-one in master array allocation Date: Tue, 22 Dec 2015 17:25:20 +0200 Message-Id: <1450797923-23072-7-git-send-email-alexander.shishkin@linux.intel.com> X-Mailer: git-send-email 2.6.4 In-Reply-To: <1450797923-23072-1-git-send-email-alexander.shishkin@linux.intel.com> References: <1450797923-23072-1-git-send-email-alexander.shishkin@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chunyan Zhang Since both sw_start and sw_end are master indices, the size of array that holds them is sw_end - sw_start + 1, which the current code gets wrong, allocating one item less than required. This patch corrects the allocation size, avoiding potential slab corruption. Signed-off-by: Chunyan Zhang [alexander.shishkin@linux.intel.com: re-wrote the commit message] Signed-off-by: Alexander Shishkin --- drivers/hwtracing/stm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c index ddcb606ace..40a8b79ab7 100644 --- a/drivers/hwtracing/stm/core.c +++ b/drivers/hwtracing/stm/core.c @@ -618,7 +618,7 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data, if (!stm_data->packet || !stm_data->sw_nchannels) return -EINVAL; - nmasters = stm_data->sw_end - stm_data->sw_start; + nmasters = stm_data->sw_end - stm_data->sw_start + 1; stm = kzalloc(sizeof(*stm) + nmasters * sizeof(void *), GFP_KERNEL); if (!stm) return -ENOMEM; -- 2.6.4