From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755273AbbLWBNX (ORCPT ); Tue, 22 Dec 2015 20:13:23 -0500 Received: from smtprelay0196.hostedemail.com ([216.40.44.196]:44531 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751444AbbLWBNU (ORCPT ); Tue, 22 Dec 2015 20:13:20 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 26,1.8,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2505:2553:2559:2562:2731:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4823:5007:6261:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13311:13357:13894:14659:21080:21088:30012:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: goose40_1bf2c0f48f734 X-Filterd-Recvd-Size: 2322 Message-ID: <1450833190.3537.2.camel@perches.com> Subject: Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp From: Joe Perches To: Finn Thain Cc: "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" Date: Tue, 22 Dec 2015 17:13:10 -0800 In-Reply-To: References: <20151222011737.980475848@telegraphics.com.au> <20151222011756.506380156@telegraphics.com.au> <1450795615.21677.10.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-12-23 at 11:56 +1100, Finn Thain wrote: > On Tue, 22 Dec 2015, Joe Perches wrote: > > > On Tue, 2015-12-22 at 12:18 +1100, Finn Thain wrote: > > > This patch is just the result of two substitutions. The first removes  > > > any tabs and spaces at the end of the line. The second replaces runs  > > > of tabs and spaces at the beginning of comment lines with a single  > > > space. > >  > > I think the second of these isn't done well. > > The aim of this patch is not to fix code style, but to make it possible to  > compare these two files so that the fork can be repaired. Regexp is very  > helpful in creating uniformity (and a minimal diff). > > If this was a coding style issue, we would be discussing the use of  > kernel-doc format for the affected comments, not whitespace. > > > Many of these comments post reformatting are > > much worse to read because of lost alignment. > > You exaggerate a very trivial point. I prefer that all patches be improvements. > I admit that a small proportion of comments are slightly less readable.  > But it is the diff that needs to be readable in order to resolve the fork. diff -w works well.