From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756909AbbLWNhQ (ORCPT ); Wed, 23 Dec 2015 08:37:16 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33983 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbbLWNhO (ORCPT ); Wed, 23 Dec 2015 08:37:14 -0500 From: Sudip Mukherjee To: Keith Busch , Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Sudip Mukherjee Subject: [PATCH] nvme: arrange header files Date: Wed, 23 Dec 2015 19:07:07 +0530 Message-Id: <1450877827-19983-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We are having build failure with sparc allmodconfig with the error: drivers/nvme/host/pci.c:15:0: include/linux/aer.h: In function 'pci_enable_pcie_error_reporting': include/linux/aer.h:49:10: error: 'EINVAL' undeclared (first use in this function) The file aer.h is using the error values but they are defined in errno.h. So if we keep aer.h at the top of header file then we do not have any definition of EINVAL. Fixes: a0a3408ee614 ("NVMe: Add pci error handlers") Cc: Keith Busch Signed-off-by: Sudip Mukherjee --- If you insist on having the headers in alphabetical order then I can send v2 by including errno.h in aer.h sparc allmodconfig build is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/98451364 drivers/nvme/host/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 92fa1a6..1124a7a 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -12,13 +12,13 @@ * more details. */ +#include #include #include #include #include #include #include -#include #include #include #include -- 1.9.1