From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbbLZEby (ORCPT ); Fri, 25 Dec 2015 23:31:54 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:58682 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbbLZEbx (ORCPT ); Fri, 25 Dec 2015 23:31:53 -0500 Message-ID: <1451104293.6359.34.camel@decadent.org.uk> Subject: Re: [PATCH 3.2 46/77] drm: Fix an unwanted master inheritance v2 From: Ben Hutchings To: Thomas Hellstrom , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: akpm@linux-foundation.org, Dave Airlie Date: Sat, 26 Dec 2015 04:31:33 +0000 In-Reply-To: <567D4F08.9000700@vmware.com> References: <567D4F08.9000700@vmware.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-JddKKMY5OuUMcfQKm1ml" X-Mailer: Evolution 3.18.2-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.247 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-JddKKMY5OuUMcfQKm1ml Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-12-25 at 15:13 +0100, Thomas Hellstrom wrote: > On 12/24/2015 04:37 PM, Ben Hutchings wrote: > > 3.2.75-rc1 review patch.=C2=A0=C2=A0If anyone has any objections, pleas= e let me know. > >=20 > > ------------------ > >=20 > > From: Thomas Hellstrom > >=20 > > commit a0af2e538c80f3e47f1d6ddf120a153ad909e8ad upstream. [...] > > =C2=A0/** > > + * drm_new_set_master - Allocate a new master object and become master= for the > > + * associated master realm. > > + * > > + * @dev: The associated device. > > + * @fpriv: File private identifying the client. > > + * > > + * This function must be called with dev::struct_mutex held. > > + * Returns negative error code on failure. Zero on success. > > + */ > > +int drm_new_set_master(struct drm_device *dev, struct drm_file *fpriv) > > +{ > > + struct drm_master *old_master; > > + int ret; > > + > > + lockdep_assert_held_once(&dev->struct_mutex); > > + >=20 > Is lockdep_assert_held_once() backported into the 3.2 series? Patch 45/77 in this series adds it. Ben. > If not, > this line could probably be replaced by lockdep_assert_held() for stable > kernels or removed entirely. --=20 Ben Hutchings I say we take off; nuke the site from orbit. It's the only way to be sure. --=-JddKKMY5OuUMcfQKm1ml Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVn4YJee/yOyVhhEJAQruexAAhW92NyCeK0pNa06sRWrB69oyOGbqevVA PH1MW4RRECbVFqlzc8+hSrDMBceEE2g7C27Xt0UziXxJXcajoXLx45HvzipiUHS5 c+dQCcozB3aFDF0YoFs5vklw1bFZV+N4EubehDnZQ1YP8/IsnYoXjSf7bxaaA980 0Zr/95hQIuLGLnteK+WKALVdxKamxB7kPrYjMwzBk+m3emmPyc7t4FM6MXgnaec1 EwndVYphr77noIZuT8zWuL+302uYZrR2gOwB+1lqcpkq9Tuk1+wm1JZgMagzY+Ge z1STXUs/yod8bZnyQCTnkWViHDtookL/vwA7Cdrz9NsOu0XGBqut8ez3TWXzKWwM oDgUGXjk9ODp5i3446g+uRDzNLEeIaSjXsSrI88DJREFexO6t38Udp22fYoYd8N0 pwKd/5AYnNevSgnaEbxz69S/qLqmyttqK3IjSf8ugMg9XUhHaxui4aPtC0KdBUJR of8J9oXmI2Gp2bH0Y6dWev0lxVTDK4k0Dq+eWhXIFzLR518AAVsnh750Bjg2QVSf qfWmbEGaZO2UpLRHsDe3W2W7Jhye5RW1Pj+/5uaCcvDJjGfoQiDWqv9jtfk9Rc1J CPJpBW6Xk4IuwsGxk2iCeIpxveVcOoffRehvrXY3wQ4zRawGL/798wiB0EXC6Ew6 sV7QusLlnoo= =S2yt -----END PGP SIGNATURE----- --=-JddKKMY5OuUMcfQKm1ml--