From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750913AbbLZF5q (ORCPT ); Sat, 26 Dec 2015 00:57:46 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:36368 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744AbbLZF5o (ORCPT ); Sat, 26 Dec 2015 00:57:44 -0500 From: Zhi-zhou Zhang To: jistone@redhat.com, daniel.thompson@linaro.org, marc.zyngier@arm.com, mark.rutland@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, salyzyn@android.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Zhi-zhou Zhang Subject: [PATCH] arm64: entry.S: add missing trace_hardirqs_off Date: Sat, 26 Dec 2015 13:57:18 +0800 Message-Id: <1451109438-5834-1-git-send-email-zhizhou.zh@gmail.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Before calling schedule, we should trace hardirqs correctly. If not, we get following warning message when enabled CONFIG_DEBUG_LOCKDEP: [ 9.243073] DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled) [ ... ] [ 9.262681] possible reason: unannotated irqs-off. [ 9.263018] irq event stamp: 256209 [ 9.263266] hardirqs last enabled at (256209): [] el0_irq_naked+0x1c/0x24 [ 9.263820] hardirqs last disabled at (256207): [] __do_softirq+0x170/0x28c [ 9.264419] softirqs last enabled at (256208): [] __do_softirq+0x1ec/0x28c [ 9.264976] softirqs last disabled at (256189): [] irq_exit+0x9c/0xec Signed-off-by: Zhi-zhou Zhang --- arch/arm64/kernel/entry.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S index 7ed3d75..4769190 100644 --- a/arch/arm64/kernel/entry.S +++ b/arch/arm64/kernel/entry.S @@ -634,6 +634,9 @@ work_pending: bl do_notify_resume b ret_to_user work_resched: +#ifdef CONFIG_TRACE_IRQFLAGS + bl trace_hardirqs_off +#endif bl schedule /* -- 2.1.4