From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754698AbbL3LT2 (ORCPT ); Wed, 30 Dec 2015 06:19:28 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:55950 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754192AbbL3LT0 (ORCPT ); Wed, 30 Dec 2015 06:19:26 -0500 X-AuditID: cbfec7f5-f79b16d000005389-d9-5683bdbb88dd From: Andrzej Hajda To: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , lustre-devel@lists.lustre.org (moderated list:STAGING - LUSTRE PARALLEL FILESYSTEM) Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] staging: lustre: remove useless check Date: Wed, 30 Dec 2015 12:18:43 +0100 Message-id: <1451474324-15481-2-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1451474324-15481-1-git-send-email-a.hajda@samsung.com> References: <1451474324-15481-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrELMWRmVeSWpSXmKPExsVy+t/xq7q79zaHGZy+JWZxa905VouGa69Y LTbOWM9qsefML3aL5sXr2Swu75rDZnHq8AMWi7VH7rJbLP7UzOjA6XFv32EWj8V7XjJ57J+7 ht2jedENNo++LasYPT5vkgtgi+KySUnNySxLLdK3S+DKONXVwlqwmL3i/8+DLA2Ms9i6GDk5 JARMJH52fmCCsMUkLtxbDxTn4hASWMoocfPLE2YIp4lJYuKzL2AdbAKaEn833wSzRQQeMEpM OeMPUsQs8I1Rou/1LtYuRg4OYQEziSPLPUFMFgFViWWnEkHKeQWcJY68ecUIsUxO4uSxyawg NqeAi8THfUfARgoB1bS83sA+gZF3ASPDKkbR1NLkguKk9FwjveLE3OLSvHS95PzcTYyQkPu6 g3HpMatDjAIcjEo8vCeEmsOEWBPLiitzDzFKcDArifAu2AQU4k1JrKxKLcqPLyrNSS0+xCjN waIkzjtz1/sQIYH0xJLU7NTUgtQimCwTB6dUA6PKnXUZMy9VukmIc70w3VD7POjtticL2B5e ZzRcsvfzrMm2vYocNY6MIf1b2e7xfyx/+Gz788PPds+/wOIlufvwixYJl1Zuwa5753mvH+Bc pR/d17yAwbT7+lsPt/3LNi56+cR36tf3KVPWH9fW9fqw7Ow67Xg98X/HxJY2yKzK9EsRXzxh 9wsOJZbijERDLeai4kQA6GTAozUCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable reserved is unsigned so the check is always true. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/staging/lustre/lustre/llite/rw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging/lustre/lustre/llite/rw.c index 95cdb0c..2fd07a2 100644 --- a/drivers/staging/lustre/lustre/llite/rw.c +++ b/drivers/staging/lustre/lustre/llite/rw.c @@ -764,7 +764,6 @@ int ll_readahead(const struct lu_env *env, struct cl_io *io, ret = ll_read_ahead_pages(env, io, queue, ria, &reserved, mapping, &ra_end); - LASSERTF(reserved >= 0, "reserved %lu\n", reserved); if (reserved != 0) ll_ra_count_put(ll_i2sbi(inode), reserved); -- 1.9.1