From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754716AbbL3LTc (ORCPT ); Wed, 30 Dec 2015 06:19:32 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:55956 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754682AbbL3LT3 (ORCPT ); Wed, 30 Dec 2015 06:19:29 -0500 X-AuditID: cbfec7f4-f79026d00000418a-5f-5683bdbfd7d3 From: Andrzej Hajda To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-scsi@vger.kernel.org (open list:SCSI SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] scsi_transport_fc: remove useless check Date: Wed, 30 Dec 2015 12:18:44 +0100 Message-id: <1451474324-15481-3-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1451474324-15481-1-git-send-email-a.hajda@samsung.com> References: <1451474324-15481-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnluLIzCtJLcpLzFFi42I5/e/4Vd39e5vDDNZ0i1ncWneO1WLjjPWs Fv/X32axuLxrDptF9/UdbBZrj9xlt1h+/B+TA7vH4R8/mD0+Pr3F4tG3ZRWjx+dNcgEsUVw2 Kak5mWWpRfp2CVwZ/bfnsRUcZK840XOWsYFxIVsXIyeHhICJxI3Zc9ghbDGJC/fWA8W5OIQE ljJK/N64FcppYpJ4+eAiC0gVm4CmxN/NN8G6RQRSJd61H2cHKWIW+MwoMe3vdSCHg0NYwELi 3mw5kBoWAVWJ3pP9YBt4BZwl9t9ZwQixTU7i5LHJrCA2p4CLxMd9R8BmCgHVtLzewD6BkXcB I8MqRtHU0uSC4qT0XEO94sTc4tK8dL3k/NxNjJBg+rKDcfExq0OMAhyMSjy8CqLNYUKsiWXF lbmHGCU4mJVEeBdsAgrxpiRWVqUW5ccXleakFh9ilOZgURLnnbvrfYiQQHpiSWp2ampBahFM lomDU6qBsdHG7dWTnmi3PPdrn9Q/3lZosvCx3PmS+XWGn+ik7ZEXm+vOGBuv0GYy2SS9ivnn NC85qQ8HwyvnLkzcrjmp+yX3x6UHXjOq6h66bnuUUWmLi0ZpbnWUan56rnBNi3erg4rcrAl3 pHjPnYo0EGa4e/BkiLTKQZfdipWqDg8bty+ZXRq3caegEktxRqKhFnNRcSIA5f4sFCICAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org simple_strtoul returns only non-negative values and *val is unsigned so there is no possibility that *val is lesser than 0. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/scsi/scsi_transport_fc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c index 8a88226..ecf62d9 100644 --- a/drivers/scsi/scsi_transport_fc.c +++ b/drivers/scsi/scsi_transport_fc.c @@ -849,7 +849,7 @@ static int fc_str_to_dev_loss(const char *buf, unsigned long *val) char *cp; *val = simple_strtoul(buf, &cp, 0); - if ((*cp && (*cp != '\n')) || (*val < 0)) + if (*cp && (*cp != '\n')) return -EINVAL; /* * Check for overflow; dev_loss_tmo is u32 -- 1.9.1