From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753922AbbLaJ7p (ORCPT ); Thu, 31 Dec 2015 04:59:45 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:48429 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751247AbbLaJ7m (ORCPT ); Thu, 31 Dec 2015 04:59:42 -0500 X-Listener-Flag: 11101 Message-ID: <1451555942.10610.18.camel@mtksdaap41> Subject: Re: [PATCH 3/5] clk: mediatek: Add MT2701 clock support From: James Liao To: Michael Turquette CC: Matthias Brugger , Stephen Boyd , , , , , Shunli Wang , Sascha Hauer , , Date: Thu, 31 Dec 2015 17:59:02 +0800 In-Reply-To: <20151230233406.19557.35006@quark.deferred.io> References: <1451456865-44139-1-git-send-email-jamesjj.liao@mediatek.com> <1451456865-44139-4-git-send-email-jamesjj.liao@mediatek.com> <20151230233406.19557.35006@quark.deferred.io> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mike On Wed, 2015-12-30 at 15:34 -0800, Michael Turquette wrote: > Quoting James Liao (2015-12-29 22:27:43) > > +CLK_OF_DECLARE(mtk_topckgen, "mediatek,mt2701-topckgen", mtk_topckgen_init); > > +CLK_OF_DECLARE(mtk_infrasys, "mediatek,mt2701-infracfg", mtk_infrasys_init); > > +CLK_OF_DECLARE(mtk_pericfg, "mediatek,mt2701-pericfg", mtk_pericfg_init); > > +CLK_OF_DECLARE(mtk_mmsys, "mediatek,mt2701-mmsys", mtk_mmsys_init); > > +CLK_OF_DECLARE(mtk_imgsys, "mediatek,mt2701-imgsys", mtk_imgsys_init); > > +CLK_OF_DECLARE(mtk_vdecsys, "mediatek,mt2701-vdecsys", mtk_vdecsys_init); > > +CLK_OF_DECLARE(mtk_hifsys, "mediatek,mt2701-hifsys", mtk_hifsys_init); > > +CLK_OF_DECLARE(mtk_ethsys, "mediatek,mt2701-ethsys", mtk_ethsys_init); > > +CLK_OF_DECLARE(mtk_bdpsys, "mediatek,mt2701-bdpsys", mtk_bdpsys_init); > > +CLK_OF_DECLARE(mtk_apmixedsys, "mediatek,mt2701-apmixedsys", > > None of these compatible strings are documented with a binding > description in this patch series. In fact looking through > Documentation/devicetree/bindings/clock/ on the latest linux-next tag I > see that the only existing binding is mt8173-cpu-dvfs.txt. > > Am I looking in the wrong place or do we have a case of missing binding > descriptions? The binding documents are located in Documentation/devicetree/bindings/arm/mediatek/ . And I missed to add mt2701 compatible strings into it. I'll add them in next patchset. Best regards, James