From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751922AbcACNys (ORCPT <rfc822;w@1wt.eu>);
	Sun, 3 Jan 2016 08:54:48 -0500
Received: from mga01.intel.com ([192.55.52.88]:25286 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751366AbcACNyq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 3 Jan 2016 08:54:46 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,516,1444719600"; 
   d="scan'208";a="627306988"
Message-ID: <1451829283.13942.6.camel@gmail.com>
Subject: Re: [PATCH] ubifs: Fix error codes in ubifs_iget()
From: Artem Bityutskiy <dedekind1@gmail.com>
Reply-To: dedekind1@gmail.com
To: Richard Weinberger <richard@nod.at>
Cc: adrian.hunter@intel.com, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Date: Sun, 03 Jan 2016 15:54:43 +0200
In-Reply-To: <1451829092.13942.4.camel@gmail.com>
References: <1451772666-2139-1-git-send-email-richard@nod.at>
	 <1451829092.13942.4.camel@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.3 (3.18.3-1.fc23) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2016-01-03 at 15:51 +0200, Artem Bityutskiy wrote:
> On Sat, 2016-01-02 at 23:11 +0100, Richard Weinberger wrote:
> > We cannot use positive error codes in ERR_PTR().
> > IS_ERR() won't catch them.
> 
> Right, but why there is a "err = -EINVAL;" when at 'out_invalid'.

Sorry Richard, I edited the sentence and did not notice it was messy.

Here is what I wanted to say: right, but there is a "err = -EINVAL' at
the end of 'out_invalid'.