From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752378AbcACT4q (ORCPT ); Sun, 3 Jan 2016 14:56:46 -0500 Received: from mout.gmx.net ([212.227.17.22]:56756 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbcACT4m (ORCPT ); Sun, 3 Jan 2016 14:56:42 -0500 From: =?UTF-8?q?Toralf=20F=C3=B6rster?= To: linux-security-module@vger.kernel.org, linux-ext4@vger.kernel.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Toralf=20F=C3=B6rster?= Subject: [PATCH 2/2] security: use XATTR_*_PREFIX_LEN instead sizeof(...) Date: Sun, 3 Jan 2016 20:56:38 +0100 Message-Id: <1451850998-28639-2-git-send-email-toralf.foerster@gmx.de> X-Mailer: git-send-email 2.4.10 In-Reply-To: <1451850998-28639-1-git-send-email-toralf.foerster@gmx.de> References: <1451850998-28639-1-git-send-email-toralf.foerster@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:tVkJhd/jXKR0ZowXLLc01fuC2QJZlXJyhukj8B1GyBwTsBzpNZw FDMIPAjmXsKvasNXNPWBeVjhtC2h3QuVfg4gkyrzX/jmCSPB4lPTGS6V4smXiRQgKzKWKn8 J0eUkLjJ7TUEIt3edd0KjErD98kH/eyVbzuSQathx98aVr91Mkk+ldmx9Pa1GairBoJpIiY 2581CrdgjNcwa87GXPdIg== X-UI-Out-Filterresults: notjunk:1;V01:K0:JLfcGHnPjxc=:GPwRQKEd6cgG/6TdXloDw7 SzTR+rUfIpJtRkvDL3pDHVEjmPmfPZaOI1RtBN8ojV4OZQE+aZv8baUdniqA/GmLg45VTxJgw D1N8w2beE1+RJ4s6yBSJ0Mh+mwEZHx1RRaRATXPfFusn8qtoJshye10Xug1sb46ooEzmI1inJ uX7cFe/KoEcxMDssBBOdMQnh/z3593CsumiSk2UuyMrPU+mMYehYA+VujSOOKeVZW2Dea4ul8 LgnfcCo0zOex+BTEFhJduvOT0WCXvrP7CT5eJb+9PF7NA/NBLF7DZpM1sKdrm9ci3HrHm39ad k4BJBsooTGSTfEfwTlbd4YJj4rNftv63r/NT6OI7PNG4K6nx4KDtV78mgiJfUWU1S6atGCAEd Q7kEmlCvrfuvA0XeYhfEjIYNS4oWD2nmRy/xmaa2bEiV3cnNNr6b/IPkm2DOWh3QdxftXxIOH gpeNvMu/hEiXXdSyyh5L/Btdx5NfPh1VC2BpkaeOGj0T90qXMIa3I7aLXzRbS9cNFPusDhFtw hs5dL8Fog6+AnQ7uVBAyp+T7C/i7w+Dml8r01bqM91Bj94tzrzUtI1G29OaBk5CGD2D3/C2B/ K8Fy1vEYvnGiEe/HuHgOXZwG5HQUFKxZ1Yp5xvgBfNFk0EGLjK2VYsvfj5J4ag1WbFhQDSbry xl8S6+UcDaJCTRSNMjRzx7QedVZlSc7gImXUtH4sd9yCpdTHfAimF3WRn90Xo9MdsbnTfx+ch QVHOghonCHAxm7Ma0lBui1ZNyPcjfP8ZbO1RrYnSMbgtSoEBHwxi5ZEkhqQqUcyyurTkaIslg z7Puj6l Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org use the definition in include/uapi/linux/xattr.h igned-off-by: Toralf Förster --- security/commoncap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/security/commoncap.c b/security/commoncap.c index 1832cf7..907a3ef 100644 --- a/security/commoncap.c +++ b/security/commoncap.c @@ -658,7 +658,7 @@ int cap_inode_setxattr(struct dentry *dentry, const char *name, } if (!strncmp(name, XATTR_SECURITY_PREFIX, - sizeof(XATTR_SECURITY_PREFIX) - 1) && + XATTR_SECURITY_PREFIX_LEN) && !capable(CAP_SYS_ADMIN)) return -EPERM; return 0; @@ -684,7 +684,7 @@ int cap_inode_removexattr(struct dentry *dentry, const char *name) } if (!strncmp(name, XATTR_SECURITY_PREFIX, - sizeof(XATTR_SECURITY_PREFIX) - 1) && + XATTR_SECURITY_PREFIX_LEN) && !capable(CAP_SYS_ADMIN)) return -EPERM; return 0; -- 2.4.10