From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752231AbcACUEa (ORCPT ); Sun, 3 Jan 2016 15:04:30 -0500 Received: from mout.gmx.net ([212.227.15.15]:61471 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbcACUE1 (ORCPT ); Sun, 3 Jan 2016 15:04:27 -0500 From: =?UTF-8?q?Toralf=20F=C3=B6rster?= To: linux-security-module@vger.kernel.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Toralf=20F=C3=B6rster?= Subject: [PATCH 2/2] security: use XATTR_*_PREFIX_LEN instead sizeof(...) Date: Sun, 3 Jan 2016 21:04:24 +0100 Message-Id: <1451851464-29550-1-git-send-email-toralf.foerster@gmx.de> X-Mailer: git-send-email 2.4.10 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:8Lbcg8jv+rzilR98b4KYuQoSIKLTMNFYpU/BeT1Pw1JCqrYQBJ0 yAIwkaVB1lZsczFSXYBtJWE6uixv8wBePn7ePxIELG1lrWqxiSZA9F+OuYUcWMFvlvvYeJW 2JJDCB201ePTfVbnTi8dqBZbym0vPrEq+1fsWmtQiv00y39GYauOo0G2U2xeHmAfG2FZdml adxuLUjpHzdIlI5WoTTeg== X-UI-Out-Filterresults: notjunk:1;V01:K0:lQzkFdBiPLU=:mqe7LrNdu+GZWpEujW/uSu 37vE7NU07O8NyviIydCq5mf55331nSRupHgNIDnsA3+8kKqtNiWh3oD+1PCtpOwS8vR4g1mOZ l1tJsfAfERyZiqnHB5FmsmMJ+mPqf7KKpm6Vy+x12lh5n6tWAA0NYJ2ykgiW3kfTy2Yumg8mS c5reVwI0rr9lD/wO+nsHu7Mj4FJ9WRxwkV3j1+VUmDCepGYAYBBfYsJyDvfu6auuoSBoTVZpG rKa1QxcKBa9QTocHv04foFASIjnV9HZQKsSrujlGPSdJswGfiiE53YWqCC9nRyKTIAEv4ZWhB ib8X7g2XNNtoGrCS+l6jBjUlHiSKJOlNM1f/Jykl/sXpaSstSOc8MD4H6V9A7aFAs6WDbC7gR z86TWn/OoYUhHpCXYp/ropEtUsCMQYoEKGKPLwF5U/wZpfdo/4xHXt6OA4jRg0VnzEThO6RAv 3C02ept/B13YbO0UtF6wy8aqllJiOp8f+Z5zekbHV7YaWdWTPH8N4/O7FfRhyYN/2kPkUhYW/ C5u4oJeJis4vllujcmYTYfu9/DXOTkgRCeawylWZRNwvYPMkhi1874HfkwPeAlTsTyegq888+ sfgOwaf0rUdiwiPu5ZGY5cywfy+iwroUFziQnjk8H2+uBWkNj8sdYQ5GumbuulWcqwX1oYpc1 SmzCZs6LVUuW05forGrmFZr8MV2TM5XZ803O+9vbLBpPLPysbYdxVvvHSq3YkaH0smrP3lkER BFDUbLevE59OG83NwKKu3Q2yDOCWx/rr+lO512JsYMkkU+c4LlJQHBRHFvB/aDtcCzSjD+0uz s+U60vu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org use the definition in include/uapi/linux/xattr.h Signed-off-by: Toralf Förster --- security/commoncap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/security/commoncap.c b/security/commoncap.c index 1832cf7..907a3ef 100644 --- a/security/commoncap.c +++ b/security/commoncap.c @@ -658,7 +658,7 @@ int cap_inode_setxattr(struct dentry *dentry, const char *name, } if (!strncmp(name, XATTR_SECURITY_PREFIX, - sizeof(XATTR_SECURITY_PREFIX) - 1) && + XATTR_SECURITY_PREFIX_LEN) && !capable(CAP_SYS_ADMIN)) return -EPERM; return 0; @@ -684,7 +684,7 @@ int cap_inode_removexattr(struct dentry *dentry, const char *name) } if (!strncmp(name, XATTR_SECURITY_PREFIX, - sizeof(XATTR_SECURITY_PREFIX) - 1) && + XATTR_SECURITY_PREFIX_LEN) && !capable(CAP_SYS_ADMIN)) return -EPERM; return 0; -- 2.4.10