From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752579AbcADSsY (ORCPT ); Mon, 4 Jan 2016 13:48:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57886 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbcADSsW (ORCPT ); Mon, 4 Jan 2016 13:48:22 -0500 From: Laura Abbott To: Andrew Morton Cc: Laura Abbott , Russell King , Kees Cook , linux-kernel@vger.kernel.org, Arnd Bergmann Subject: [PATCH] dma-debug: Switch check from _text to _stext Date: Mon, 4 Jan 2016 10:48:12 -0800 Message-Id: <1451933292-1209-1-git-send-email-labbott@fedoraproject.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>From include/asm-generic/sections.h: /* * Usage guidelines: * _text, _data: architecture specific, don't use them in * arch-independent code * [_stext, _etext]: contains .text.* sections, may also contain * .rodata.* * and/or .init.* sections _text is not guaranteed across architectures. Architectures such as ARM may reuse parts which are not actually text and erroneously trigger a bug. Switch to using _stext which is guaranteed to contain text sections. Signed-off-by: Laura Abbott --- Came out of https://lkml.kernel.org/g/<567B1176.4000106@redhat.com> --- lib/dma-debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dma-debug.c b/lib/dma-debug.c index d34bd24..4a1515f 100644 --- a/lib/dma-debug.c +++ b/lib/dma-debug.c @@ -1181,7 +1181,7 @@ static inline bool overlap(void *addr, unsigned long len, void *start, void *end static void check_for_illegal_area(struct device *dev, void *addr, unsigned long len) { - if (overlap(addr, len, _text, _etext) || + if (overlap(addr, len, _stext, _etext) || overlap(addr, len, __start_rodata, __end_rodata)) err_printk(dev, NULL, "DMA-API: device driver maps memory from kernel text or rodata [addr=%p] [len=%lu]\n", addr, len); } -- 2.5.0