From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753826AbcADXjt (ORCPT ); Mon, 4 Jan 2016 18:39:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60616 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753627AbcADXjq (ORCPT ); Mon, 4 Jan 2016 18:39:46 -0500 Message-ID: <1451950785.2874.2.camel@redhat.com> Subject: Re: [PATCH] vfio/iommu_type1: make use of info.flags From: Alex Williamson To: Pierre Morel Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, sebott@linux.vnet.ibm.com Date: Mon, 04 Jan 2016 16:39:45 -0700 In-Reply-To: <1450872485-5271-1-git-send-email-pmorel@linux.vnet.ibm.com> References: <1450872485-5271-1-git-send-email-pmorel@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-12-23 at 13:08 +0100, Pierre Morel wrote: > The flags entry is there to tell the user that some > optional information is available. > > Since we report the iova_pgsizes signal it to the user > by setting the flags to VFIO_IOMMU_INFO_PGSIZES. > > Signed-off-by: Pierre Morel > --- >  drivers/vfio/vfio_iommu_type1.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/vfio_iommu_type1.c > b/drivers/vfio/vfio_iommu_type1.c > index 59d47cb..6f1ea3d 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -995,7 +995,7 @@ static long vfio_iommu_type1_ioctl(void > *iommu_data, >   if (info.argsz < minsz) >   return -EINVAL; >   > - info.flags = 0; > + info.flags = VFIO_IOMMU_INFO_PGSIZES; >   >   info.iova_pgsizes = vfio_pgsize_bitmap(iommu); >   Applied to my next branch for v4.5, thanks! Alex PS - I haven't lost your qemu overflow patch, sorry for the delay.