From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932065AbcAEDDz (ORCPT ); Mon, 4 Jan 2016 22:03:55 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:48012 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754023AbcAEDDt (ORCPT ); Mon, 4 Jan 2016 22:03:49 -0500 X-Original-SENDERIP: 156.147.1.121 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Steven Rostedt , Frederic Weisbecker , Andi Kleen , Wang Nan Subject: [PATCH 1/5] perf tools: Fix segfault when using -s trace_fields Date: Tue, 5 Jan 2016 12:03:43 +0900 Message-Id: <1451963027-16973-1-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 2.6.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the 'trace_fields' sort key is used explicitly for non-tracepoint events, it'll get segfault since it assumed evsel->tp_format was set. Skip those events in add_all_dynamic_fields(). Signed-off-by: Namhyung Kim --- tools/perf/util/sort.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index e558e87cafaf..59c4c8586d79 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -1955,6 +1955,9 @@ static int add_all_dynamic_fields(struct perf_evlist *evlist, bool raw_trace) struct perf_evsel *evsel; evlist__for_each(evlist, evsel) { + if (evsel->attr.type != PERF_TYPE_TRACEPOINT) + continue; + ret = add_evsel_fields(evsel, raw_trace); if (ret < 0) return ret; -- 2.6.4