From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752026AbcAEQUa (ORCPT ); Tue, 5 Jan 2016 11:20:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42491 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbcAEQU2 (ORCPT ); Tue, 5 Jan 2016 11:20:28 -0500 Date: Tue, 5 Jan 2016 18:20:24 +0200 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Gleb Natapov , Paolo Bonzini , Christian Borntraeger , Cornelia Huck , Martin Schwidefsky , Heiko Carstens , kvm@vger.kernel.org, linux-s390@vger.kernel.org Subject: [PATCH] kvm/s390: drop unpaired smp_mb Message-ID: <1452010811-25486-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mutt-Fcc: =sent Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org smp_mb on vcpu destroy isn't paired with anything, violating pairing rules, and seems to be useless. Drop it. Signed-off-by: Michael S. Tsirkin --- Untested. arch/s390/kvm/kvm-s390.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c index 8465892..7305d2c 100644 --- a/arch/s390/kvm/kvm-s390.c +++ b/arch/s390/kvm/kvm-s390.c @@ -1195,7 +1195,6 @@ void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu) (__u64) vcpu->arch.sie_block) vcpu->kvm->arch.sca->cpu[vcpu->vcpu_id].sda = 0; } - smp_mb(); if (kvm_is_ucontrol(vcpu->kvm)) gmap_free(vcpu->arch.gmap); -- MST