From: Peter Senna Tschudin <peter.senna@collabora.com>
To: thomas@winischhofer.net, gregkh@linuxfoundation.org,
trivial@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Peter Senna Tschudin <peter.senna@gmail.com>,
Peter Senna Tschudin <peter.senna@collabora.com>
Subject: [PATCH 5/5] usb-misc: sisusbvga: Remove null test before kfree()
Date: Tue, 5 Jan 2016 17:54:10 +0100 [thread overview]
Message-ID: <1452012850-6990-6-git-send-email-peter.senna@collabora.com> (raw)
In-Reply-To: <1452012850-6990-1-git-send-email-peter.senna@collabora.com>
From: Peter Senna Tschudin <peter.senna@gmail.com>
This patch removes null test before calls to kfree() as kfree() can
handle null pointers safely.
Signed-off-by: Peter Senna Tschudin <peter.senna@collabora.com>
---
Tested by compilation only.
drivers/usb/misc/sisusbvga/sisusb.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index 875e365..8d0b29a 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -76,15 +76,11 @@ static void sisusb_free_buffers(struct sisusb_usb_data *sisusb)
int i;
for (i = 0; i < NUMOBUFS; i++) {
- if (sisusb->obuf[i]) {
- kfree(sisusb->obuf[i]);
- sisusb->obuf[i] = NULL;
- }
- }
- if (sisusb->ibuf) {
- kfree(sisusb->ibuf);
- sisusb->ibuf = NULL;
+ kfree(sisusb->obuf[i]);
+ sisusb->obuf[i] = NULL;
}
+ kfree(sisusb->ibuf);
+ sisusb->ibuf = NULL;
}
static void sisusb_free_urbs(struct sisusb_usb_data *sisusb)
--
2.5.0
next prev parent reply other threads:[~2016-01-05 16:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 16:54 [PATCH 0/5] usb-misc: cleanup sisusbvga Peter Senna Tschudin
2016-01-05 16:54 ` [PATCH 1/5] usb-misc: sisusbvga: Fix coding style: white space Peter Senna Tschudin
2016-01-05 16:54 ` [PATCH 2/5] usb-misc: sisusbvga: Fix trivial coding style Peter Senna Tschudin
2016-01-05 16:54 ` [PATCH 3/5] usb-misc: sisusbvga: Remove assignments from if tests Peter Senna Tschudin
2016-01-05 16:54 ` [PATCH 4/5] usb-misc: sisusbvga: Remove kmalloc logs and fix error path Peter Senna Tschudin
2016-01-06 18:28 ` Sergei Shtylyov
2016-01-07 15:19 ` Peter Senna Tschudin
2016-01-05 16:54 ` Peter Senna Tschudin [this message]
2016-01-05 18:53 ` [PATCH 0/5] usb-misc: cleanup sisusbvga Joe Perches
2016-01-06 15:30 ` Peter Senna Tschudin
2016-01-06 16:04 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452012850-6990-6-git-send-email-peter.senna@collabora.com \
--to=peter.senna@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=thomas@winischhofer.net \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®